Skip to content
This repository was archived by the owner on Sep 19, 2022. It is now read-only.

Commit 61fefa8

Browse files
authored
Update openapi-gen to not rely on vendor (#274)
1 parent 7c4dd8d commit 61fefa8

File tree

5 files changed

+138
-281
lines changed

5 files changed

+138
-281
lines changed

Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,4 @@ COPY --from=build-image /go/src/github.com/kubeflow/pytorch-operator/pytorch-ope
1313

1414
COPY third_party/library/license.txt /license.txt
1515

16-
RUN mkdir -p /vendor
17-
1816
ENTRYPOINT ["/pytorch-operator.v1", "-alsologtostderr"]

go.mod

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ replace (
4949
k8s.io/csi-translation-lib => k8s.io/csi-translation-lib v0.15.9
5050
k8s.io/kube-aggregator => k8s.io/kube-aggregator v0.15.9
5151
k8s.io/kube-controller-manager => k8s.io/kube-controller-manager v0.15.9
52+
k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20190228160746-b3a7cee44a30
5253
k8s.io/kube-proxy => k8s.io/kube-proxy v0.15.9
5354
k8s.io/kube-scheduler => k8s.io/kube-scheduler v0.15.9
5455
k8s.io/kubectl => k8s.io/kubectl v0.15.13-beta.0

go.sum

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -545,8 +545,6 @@ k8s.io/klog v0.4.0 h1:lCJCxf/LIowc2IGS9TPjWDyXY4nOmdGdfcwwDQCOURQ=
545545
k8s.io/klog v0.4.0/go.mod h1:4Bi6QPql/J/LkTDqv7R/cd3hPo4k2DG6Ptcz060Ez5I=
546546
k8s.io/kube-aggregator v0.15.9/go.mod h1:0qkV3is34K22a6LzgE0+85HGp+V84d7jabS6alqUomU=
547547
k8s.io/kube-controller-manager v0.15.9/go.mod h1:W4Hi0ISvsMECIvYCbP/eYHp0/niHkDF7hIfS0c7xWjQ=
548-
k8s.io/kube-openapi v0.0.0-20180509051136-39cb288412c4 h1:gW+EUB2I96nbxVenV/8ctfbACsHP+yxlT2dhMCsiy+s=
549-
k8s.io/kube-openapi v0.0.0-20180509051136-39cb288412c4/go.mod h1:BXM9ceUBTj2QnfH2MK1odQs778ajze1RxcmP6S8RVVc=
550548
k8s.io/kube-openapi v0.0.0-20190228160746-b3a7cee44a30 h1:TRb4wNWoBVrH9plmkp2q86FIDppkbrEXdXlxU3a3BMI=
551549
k8s.io/kube-openapi v0.0.0-20190228160746-b3a7cee44a30/go.mod h1:BXM9ceUBTj2QnfH2MK1odQs778ajze1RxcmP6S8RVVc=
552550
k8s.io/kube-proxy v0.15.9/go.mod h1:Pee8FfheAGfwSE/WVhzle0YAYJaJ8D9O36HlBmSlbjA=

hack/python-sdk/gen-sdk.sh

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,22 @@ if [ -z "${GOPATH:-}" ]; then
2828
export GOPATH=$(go env GOPATH)
2929
fi
3030

31+
# Grab kube-openapi version from go.sum
32+
OPENAPI_VERSION=$(grep 'k8s.io/kube-openapi' go.sum | awk '{print $2}' | head -1)
33+
OPENAPI_PKG=$(echo `go env GOPATH`"/pkg/mod/k8s.io/kube-openapi@${OPENAPI_VERSION}")
34+
35+
if [[ ! -d ${OPENAPI_PKG} ]]; then
36+
echo "${OPENAPI_PKG} is missing. Running 'go mod download'."
37+
go mod download
38+
fi
39+
40+
echo ">> Using ${OPENAPI_PKG}"
41+
42+
echo "Building openapi-gen"
43+
go build -o openapi-gen ${OPENAPI_PKG}/cmd/openapi-gen
44+
3145
echo "Generating OpenAPI specification ..."
32-
go run vendor/k8s.io/code-generator/cmd/openapi-gen/main.go --input-dirs github.com/kubeflow/pytorch-operator/pkg/apis/pytorch/v1,github.com/kubeflow/common/job_controller/api/v1 --output-package github.com/kubeflow/pytorch-operator/pkg/apis/pytorch/v1 --go-header-file hack/boilerplate/boilerplate.go.txt
46+
./openapi-gen --input-dirs github.com/kubeflow/pytorch-operator/pkg/apis/pytorch/v1 --output-package github.com/kubeflow/pytorch-operator/pkg/apis/pytorch/v1 --go-header-file hack/boilerplate/boilerplate.go.txt
3347

3448
echo "Generating swagger file ..."
3549
go run hack/python-sdk/main.go 0.1 > ${SWAGGER_CODEGEN_FILE}

0 commit comments

Comments
 (0)