Merge pull request #281 from brendandburns/close

Close the response body in the case of error.

Author: brendandburns

examples/src/main/java/io/kubernetes/client/examples/WatchExample.java

@@ -39,8 +39,12 @@ public static void main(String[] args) throws IOException, ApiException {
                 null, null, null, null, null, 5, null, null, Boolean.TRUE, null, null),
             new TypeToken<Watch.Response<V1Namespace>>() {}.getType());
 
-    for (Watch.Response<V1Namespace> item : watch) {
-      System.out.printf("%s : %s%n", item.type, item.object.getMetadata().getName());
+    try {
+      for (Watch.Response<V1Namespace> item : watch) {
+        System.out.printf("%s : %s%n", item.type, item.object.getMetadata().getName());
+      }
+    } finally {
+      watch.close();
     }
   }
 }

util/src/main/java/io/kubernetes/client/util/Watch.java

@@ -34,7 +34,10 @@
  * CoreV1Api.listNamespaceCall and set watch to True and watch the changes to namespaces.
  */
 public class Watch<T>
-    implements Iterable<Watch.Response<T>>, Iterator<Watch.Response<T>>, java.io.Closeable {
+    implements Iterable<Watch.Response<T>>,
+        Iterator<Watch.Response<T>>,
+        java.io.Closeable,
+        AutoCloseable {
 
   private static final Logger log = LoggerFactory.getLogger(Watch.class);
 
@@ -91,13 +94,13 @@ public static <T> Watch<T> createWatch(ApiClient client, Call call, Type watchTy
       com.squareup.okhttp.Response response = call.execute();
       if (!response.isSuccessful()) {
         String respBody = null;
-        if (response.body() != null) {
-          try {
+        try (ResponseBody body = response.body()) {
+          if (body != null) {
             respBody = response.body().string();
-          } catch (IOException e) {
-            throw new ApiException(
-                response.message(), e, response.code(), response.headers().toMultimap());
           }
+        } catch (IOException e) {
+          throw new ApiException(
+              response.message(), e, response.code(), response.headers().toMultimap());
         }
         throw new ApiException(
             response.message(), response.code(), response.headers().toMultimap(), respBody);