Skip to content

Release Quickstart Script Missing Important Updates #1044

Open
@danehans

Description

@danehans

The hack/release-quickstart.sh script contains the following bugs:

  • Release: Updates EPP tag sed for quickstart script #1035 generalized the sed command to manage the tag for the EPP image. However, the previous sed should be used when RC is set and the current logic should be used when RC is unset.
  • A lora-syncer tagged image is created when a release is cut. Still, the vLLM CPU, GPU and Sim manifests are not updated to set the image tag like it does for the EPP image tag in the same manifests. Here's an example of the e-extension/blob/v0.4.0/config/manifests/vllm/gpu-deployment.yaml#L158 that still uses the main tag.
  • The VERSION env var in site-src/guides/index.md is not updated.
  • All the references to main resources should use the tagged branch instead, i.e. kubectl apply -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/raw/main/config/manifests/vllm/gpu-deployment.yaml should be kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/$VERSION/config/manifests/vllm/gpu-deployment.yaml. This ensures the entire quickstart guide algins with a release.

Metadata

Metadata

Assignees

Labels

good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions