🐛 Downgrade Go to 1.24.6 and standardize version across codebase #5186
+31
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
go-certmanager-downgrade-for-release
branch
3 times, most recently
from
77bd060 to
89f28b5
Compare
k8s-ci-robot
added
size/L
camilamacedo86
force-pushed
the
go-certmanager-downgrade-for-release
branch
2 times, most recently
from
66af85a to
75dd88d
Compare
camilamacedo86
changed the title
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
go-certmanager-downgrade-for-release
branch
2 times, most recently
from
b91c726 to
761bdb9
Compare
k8s-ci-robot
added
size/XL
camilamacedo86
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
go-certmanager-downgrade-for-release
branch
from
761bdb9 to
aadb985
Compare
k8s-ci-robot
added
size/L
camilamacedo86
force-pushed
the
go-certmanager-downgrade-for-release
branch
2 times, most recently
from
48a952e to
84383cb
Compare
k8s-ci-robot
added
size/M
camilamacedo86
force-pushed
the
go-certmanager-downgrade-for-release
branch
from
84383cb to
3cbeee9
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
commented
Nov 12, 2025
| module sigs.k8s.io/kubebuilder/v4 | ||
|
|
||
| go 1.25.0 | ||
| go 1.24.6 |
Member
Author
There was a problem hiding this comment.
We upgrade the version for the tooling to workaround that was properly addressed with: #5194
In order to push a release with a go version that address CVE and still compatible with the libs adopt we should stick with 1.24.6. Let;s just upgrade to 1.25 when we bump controller-runtime using it.
Contributor
|
@camilamacedo86: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Member
Author
|
/test pull-kubebuilder-e2e-k8s-1-33-0 |
camilamacedo86
merged commit 05c6782
into
kubernetes-sigs:master
34 of 39 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR downgrades the Go version to 1.24.6 and ensures consistent usage across all modules and build configurations.
Motivation