-
Notifications
You must be signed in to change notification settings - Fork 1.6k
📖 (docs/UI): Book theme customizations #5187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vitorfloriano The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @vitorfloriano. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
What is missing in this one? |
|
Hi @camilamacedo86 I'm just checking some accessibility issues in my choice of colors, mainly contrast. I'm using Chrome Dev Tools to analyze CSS accessibility issues and correcting them little by little. See: https://developer.chrome.com/docs/devtools/accessibility/contrast and https://web.dev/articles/color-and-contrast-accessibility The feedback we got was that some parts were not very readable and distinguishable, so I'm focusing on that now. ALSO, another thing I would highly suggest: remove the custom version picker dropdown menu entirely.
I think it adds overhead (custom HTML, CSS and JS) and is a little redundant since we already have a callout on the first page for that. We could simply improve the CSS on the note and completely remove the custom dropdown. That way we would reduce the number of customizations on the default template and make it easier to migrate to newer versions of template in the future. WDYT? |

This PR brings several customizations to the book UI:
Related to #4862.