-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Description
Context
The assignedTxs field on GCRMain accounts was defined but never populated. A fix was added to HandleGCR.apply() to track transactions for the sender account.
What was done
- Modified
HandleGCR.apply()to addtx.hashtosender.assignedTxsafter successful GCR edit operations - Added
addAssignedTx()helper method to handle the update with duplicate prevention
What needs to be audited
- Verify all transaction types populate assignedTxs:
balance✓ (goes through HandleGCR.apply)nonce✓ (goes through HandleGCR.apply)identity✓ (goes through HandleGCR.apply)storageProgram✓ (goes through HandleGCR.apply)tlsnotary✓ (goes through HandleGCR.apply)assign- TODO implementationsubnetsTx- TODO implementationsmartContract- TODO implementationescrow- TODO implementation
- Check if recipients should also have assignedTxs updated:
- For transfers, should the receiver also have the tx in their assignedTxs?
- For storage programs, should the storage address have a reference?
- Verify historical transactions:
- Existing accounts may have empty assignedTxs
- Consider migration script to backfill from chain data
Technical Details
- File:
src/libs/blockchain/gcr/handleGCR.ts - Method:
HandleGCR.apply()andHandleGCR.addAssignedTx() - Entity:
GCRMain.assignedTxs: string[]
Metadata
Metadata
Assignees
Labels
No labels