-
-
Notifications
You must be signed in to change notification settings - Fork 4
Lagoon init/pull/push improvements #11
Copy link
Copy link
Open
Labels
Description
We're feature complete on Lagoon init/pull/push but there are a few areas we could and should improve:
- On init/pull/push when you see a list of "authorizations" to use this is expressed as emails but it should also probably include the lagoon instance url. We also should probably remove "duplicates" eg only show the latest authorization for a given email/lagoon combination.
- We do a lot of unneeded calls to the Lagoon API because we are creating multiple instances of the Lagoon API client. We should share a single client instance so that we do not need to make unneeded calls. Eg calling
api.authshould just returnthis.tokenif its set instead of authing again. Ditto forapi.getProjects. NOTE: @mikemilano had it this way originally but @pirog removed it for expediency and because his brain was hurting.
Reactions are currently unavailable