Issue with task scheduler grouping

[Mlekar]

Laravel Version

12.21.0

PHP Version

8.4.11

Database Driver & Version

No response

Description

There seems to be an issue with grouping tasks in the scheduler in a specific way - I believe it's the same issue as specified in pull 53427 in the last comment made by @decadence.

I believe the issues arises when grouping tasks (with subgroups) in a specific way such as e.g.:

Schedule::days([1, 2, 3, 4, 5, 6])->group(function () {
    Schedule::between('07:00', '21:00')->group(function () {
        Schedule::call(Task1::class)->everyMinute();
        Schedule::call(Task2::class)->everyMinute();
    });

    Schedule::call(Task3::class)->at('23:45');
});

If we group the tasks in this way, we'd expect Task1 and Task2 to run every minute between 07:00 and 21:00 from Monday to Saturday (which works correctly) and Task3 to run once at 23:45 from Mon - Sat (which isn't the case) - Task3 never runs in this case, which we think is because the scheduler gets confused somehow and wants to run Task3 between 07:00 and 21:00 at 23:45.

If we schedule Task3 to run at an hour between 07:00 and 21:00 it works as expected, such as in the example below:

Schedule::days([1, 2, 3, 4, 5, 6])->group(function () {
    Schedule::between('07:00', '21:00')->group(function () {
        Schedule::call(Task1::class)->everyMinute();
        Schedule::call(Task2::class)->everyMinute();
    });

    Schedule::call(Task3::class)->at('08:00');
});

So it seems the call to between in the subgroup somehow messes with anything defined in the main group. We've resolved it for now by defining the schedule like:

Schedule::days([1, 2, 3, 4, 5, 6])->between('07:00', '21:00')->group(function () {
        Schedule::call(Task1::class)->everyMinute();
        Schedule::call(Task2::class)->everyMinute();
});

Schedule::days([1, 2, 3, 4, 5, 6])->group(function () {
        Schedule::call(Task3::class)->at('23:45');
});

Not sure if this is an actual bug or not, but I feel like approach nr. 1 should work, since nested grouping is supposedly supported and works in most cases except cases where you define different times with between and at and such.

Steps To Reproduce

Define some scheduler tasks in groups in a similar way as described above. The task that should run outside of the between window once per day will not run unless its time is within the between window.

[crynobone]

Hey there, thanks for reporting this issue.

We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here?

Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.

laravel new bug-report --github="--public"

Do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.

Thanks!

[Mlekar]

Hello,

I'm not that savvy with Git but I've done as you asked.

You can find the repository in question here - https://github.com/Mlekar/scheduler-bug-report

One initial commit and then a single commit with the code that doesn't work.

[MrPunyapal]

@Mlekar maybe try like this?

Schedule::days([1, 2, 3, 4, 5, 6])->group(function (Schedule $schedule) {
    $schedule->between('07:00', '21:00')->group(function (Schedule $schedule) {
        $schedule->call(Task1::class)->everyMinute();
        $schedule->call(Task2::class)->everyMinute();
    });

    $schedule->call(Task3::class)->at('08:00');
});

[github-actions]

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!