support function attributes with array arguments (#113)

Author: erikgaal

src/Support/ReflectionClosure.php

@@ -685,7 +685,7 @@ public function getCode()
 
             $name = $attribute->getName();
             $arguments = implode(', ', array_map(function ($argument, $key) {
-                $argument = sprintf("'%s'", str_replace("'", "\\'", $argument));
+                $argument = var_export($argument, true);
 
                 if (is_string($key)) {
                     $argument = sprintf('%s: %s', $key, $argument);

tests/ReflectionClosurePhp81Test.php

@@ -589,8 +589,8 @@ function () {
         return true;
     };
 
-    $e = <<<EOF
-#[MyAttribute('My " \' Argument 1', 'Tests\Fixtures\Model')]
+    $e = <<<'EOF'
+#[MyAttribute('My " \' Argument 1', 'Tests\\Fixtures\\Model')]
 function () {
         return true;
     }
@@ -606,8 +606,8 @@ function () {
         return false;
     };
 
-    $e = <<<EOF
-#[MyAttribute(string: 'My " \' Argument 1', model: 'Tests\Fixtures\Model')]
+    $e = <<<'EOF'
+#[MyAttribute(string: 'My " \' Argument 1', model: 'Tests\\Fixtures\\Model')]
 function () {
         return false;
     }
@@ -621,12 +621,32 @@ function () {
 
     $f = (new SerializerPhp81Controller())->publicGetter(...);
 
-    $e = <<<EOF
+    $e = <<<'EOF'
 #[Tests\Fixtures\ModelAttribute()]
-#[MyAttribute('My " \' Argument 1', 'Tests\Fixtures\Model')]
+#[MyAttribute('My " \' Argument 1', 'Tests\\Fixtures\\Model')]
 function ()
     {
-        return \$this->privateGetter();
+        return $this->privateGetter();
+    }
+EOF;
+
+    expect($f)->toBeCode($e);
+});
+
+test('function attributes with array arguments', function () {
+    $model = new Model();
+
+    $f = #[MyAttribute('My Argument', ['one', 'two'])] function (): bool {
+        return true;
+    };
+
+    $e = <<<'EOF'
+#[MyAttribute('My Argument', array (
+  0 => 'one',
+  1 => 'two',
+))]
+function (): bool {
+        return true;
     }
 EOF;
 

tests/SerializerPhp81Test.php

@@ -386,7 +386,30 @@ enum SerializerScopedBackedEnum: string {
         fn ($attribute) => $attribute
             ->getName()->toBe(MyAttribute::class)
             ->getArguments()->toBe([
-                'My " \' Argument 1', Model::class,
+                'My " \' Argument 1', 'Tests\Fixtures\Model',
+            ])
+    );
+
+    expect($f())->toBeFalse();
+})->with('serializers');
+
+test('function attributes with array arguments', function () {
+    $model = new Model();
+
+    $f = #[MyAttribute("My Argument", ["one", "two"])] function () {
+        return false;
+    };
+
+    $f = s($f);
+
+    $reflector = new ReflectionFunction($f);
+
+    expect($reflector->getAttributes())->sequence(
+        fn ($attribute) => $attribute
+            ->getName()->toBe(MyAttribute::class)
+            ->getArguments()->toBe([
+                "My Argument",
+                ["one", "two"],
             ])
     );
 
@@ -571,12 +594,12 @@ enum SerializerScopedBackedEnum: string {
             ->getName()->toBe(MyAttribute::class)
             ->getArguments()->toBe([
                 'string' => 'My " \' Argument 1',
-                'model' => Model::class,
+                'model' => 'Tests\\Fixtures\\Model',
             ]);
 
         expect($attribute->value->newInstance())
             ->string->toBe('My " \' Argument 1')
-            ->model->toBe(Model::class);
+            ->model->toBe('Tests\\Fixtures\\Model');
     });
 
     expect($f())->toBeFalse();
@@ -596,7 +619,7 @@ enum SerializerScopedBackedEnum: string {
         fn ($attribute) => $attribute
             ->getName()->toBe(MyAttribute::class)
             ->getArguments()->toBe([
-                'My " \' Argument 1', Model::class,
+                'My " \' Argument 1', 'Tests\\Fixtures\\Model',
             ])
     );