Skip to content

Commit b98dc99

Browse files
authored
ci: use explicit comparison to string 'true' in release-please.yml (#51)
Step outputs are cast to strings. So `false` == `'false'`, and `true == 'true'`. Right now the `'false'` is output from release-please's `prs_created`. And in an expression, that is evaluated as `true`. Because it's a non-empty string, I think? Instead, compare against the actual string 'true'.
1 parent ce60b02 commit b98dc99

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/release-please.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,31 +21,31 @@ jobs:
2121
token: ${{ secrets.GITHUB_TOKEN }}
2222

2323
- uses: actions/checkout@v4
24-
if: ${{ steps.release.outputs.prs_created }}
24+
if: ${{ steps.release.outputs.prs_created == 'true' }}
2525

2626
- name: Update launchdarkly-server-sdk rockspec
2727
uses: ./.github/actions/update-versions
28-
if: ${{ steps.release.outputs.prs_created }}
28+
if: ${{ steps.release.outputs.prs_created == 'true' }}
2929
with:
3030
package: launchdarkly-server-sdk
3131
branch: ${{ fromJSON(steps.release.outputs.pr).headBranchName }}
3232

3333
- name: Update launchdarkly-server-sdk-redis rockspec
3434
uses: ./.github/actions/update-versions
35-
if: ${{ steps.release.outputs.prs_created }}
35+
if: ${{ steps.release.outputs.prs_created == 'true' }}
3636
with:
3737
package: launchdarkly-server-sdk-redis
3838
branch: ${{ fromJSON(steps.release.outputs.pr).headBranchName }}
3939

4040
- name: Build and Test
41-
if: ${{ steps.release.outputs.release_created }}
41+
if: ${{ steps.release.outputs.release_created == 'true' }}
4242
uses: ./.github/actions/ci
4343

4444
- name: Build documentation
45-
if: ${{ steps.release.outputs.release_created }}
45+
if: ${{ steps.release.outputs.release_created == 'true' }}
4646
uses: ./.github/actions/build-docs
4747

4848
- uses: ./.github/actions/publish-docs
49-
if: ${{ steps.release.outputs.release_created }}
49+
if: ${{ steps.release.outputs.release_created == 'true' }}
5050
with:
5151
token: ${{ secrets.GITHUB_TOKEN }}

0 commit comments

Comments
 (0)