ci: remove rockspec-info.yml from release-please extra-files (#79)

This should _actually_ fix release please!

The root cause of the errors seems to have been that you cannot update a
Github workflow file using `extra-files` in a release please manifest.
This is disallowed by the Github API.

I've refactored the `rockspec-info` workflow to not need to be updated
at all. Instead, it grabs the current version from the existing
`.release-please-manifest`. I should have done this in the first place
as it's much cleaner.

Author: cwaldren-ld

.github/workflows/release-please.yml

@@ -9,8 +9,94 @@ on:
 jobs:
   release-please:
     runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write # Needed to create the release PR
+      contents: write # Needed to generate the release
+
+    outputs:
+      release_created: ${{ steps.release.outputs.release_created }}
+      prs_created: ${{ steps.release.outputs.prs_created }}
+      pr_branch_name: ${{ steps.release.outputs.prs_created == 'true' && fromJSON(steps.release.outputs.pr).headBranchName || '' }}
     steps:
-      - uses: cwaldren-ld/release-please-action@c20bc7716919838e71934160b59925db0b3e59af
+      - uses: google-github-actions/release-please-action@v4
         id: release
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
+          target-branch: ${{ github.ref_name }}
+
+  rockspec-info:
+    needs: release-please
+    uses: ./.github/workflows/rockspec-info.yml
+
+  update-release-pr:
+    needs: release-please
+    if: ${{ needs.release-please.outputs.prs_created == 'true' }}
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Update launchdarkly-server-sdk rockspec
+        uses: ./.github/actions/update-versions
+        with:
+          package: launchdarkly-server-sdk
+          branch: ${{ needs.release-please.outputs.pr_branch_name }}
+
+      - name: Update launchdarkly-server-sdk-redis rockspec
+        uses: ./.github/actions/update-versions
+        with:
+          package: launchdarkly-server-sdk-redis
+          branch: ${{ needs.release-please.outputs.pr_branch_name }}
+
+  publish-docs:
+    permissions:
+      contents: write # Needed to publish to Github Pages
+    needs: release-please
+    if: ${{ needs.release-please.outputs.release_created == 'true' }}
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Build documentation
+        uses: ./.github/actions/build-docs
+
+      - name: Publish docs
+        uses: ./.github/actions/publish-docs
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+
+  publish-server:
+    permissions: # Needed for access to the LuaRocks token
+      id-token: write
+      contents: read
+    needs: [release-please, rockspec-info]
+    if: ${{ needs.release-please.outputs.release_created == 'true' }}
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.0.2
+        name: 'Get LuaRocks token'
+        with:
+          aws_assume_role: ${{ vars.AWS_ROLE_ARN }}
+          ssm_parameter_pairs: '/production/common/releasing/luarocks/token = LUAROCKS_API_TOKEN'
+      - uses: ./.github/actions/publish
+        name: Publish server package
+        with:
+          dry_run: 'false'
+          rockspec: ${{ fromJSON(needs.rockspec-info.outputs.info).server }}
+
+  publish-redis:
+    permissions: # Needed for access to the LuaRocks token
+      id-token: write
+      contents: read
+    needs: [ publish-server, rockspec-info ]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.0.2
+        name: 'Get LuaRocks token'
+        with:
+          aws_assume_role: ${{ vars.AWS_ROLE_ARN }}
+          ssm_parameter_pairs: '/production/common/releasing/luarocks/token = LUAROCKS_API_TOKEN'
+      - uses: ./.github/actions/publish
+        name: Publish redis package
+        with:
+          dry_run: 'false'
+          rockspec: ${{ fromJSON(needs.rockspec-info.outputs.info).redis }}

.github/workflows/rockspec-info.yml

@@ -6,24 +6,24 @@ on:
         description: "JSON object with rockspec info"
         value: ${{ jobs.rockspec-info.outputs.info }}
 
-env:
-  LUA_SERVER_VERSION: "2.0.2"  # {x-release-please-version}
-  LUA_SERVER_REDIS_VERSION: "2.0.2" # {x-release-please-version}
-
-
 jobs:
   rockspec-info:
     runs-on: ubuntu-latest
     outputs:
       info: ${{ steps.pkg-info.outputs.info }}
     steps:
       - uses: actions/checkout@v4
+      - name: Fetch release please manifest
+        id: manifest
+        run: |
+            version=$(jq '."."' < .release-please-manifest.json)
+            echo "version=$version" >> $GITHUB_OUTPUT
       - name: Construct rockspec package names
         id: pkg-info
         run: |
           echo 'info<<EOF' >> $GITHUB_OUTPUT
           echo '"{' >> $GITHUB_OUTPUT
-          echo '\"server\":{\"version\":\"${{ env.LUA_SERVER_VERSION}}\",\"rockspec\":\"launchdarkly-server-sdk-${{ env.LUA_SERVER_VERSION }}-0.rockspec\"},' >> $GITHUB_OUTPUT
-          echo '\"redis\":{\"version\":\"${{ env.LUA_SERVER_REDIS_VERSION}}\",\"rockspec\":\"launchdarkly-server-sdk-redis-${{ env.LUA_SERVER_REDIS_VERSION }}-0.rockspec\"}' >> $GITHUB_OUTPUT
+          echo '\"server\":{\"version\":\"${{ steps.manifest.outputs.version }}\",\"rockspec\":\"launchdarkly-server-sdk-${{ steps.manifest.outputs.version }}-0.rockspec\"},' >> $GITHUB_OUTPUT
+          echo '\"redis\":{\"version\":\"${{ steps.manifest.outputs.version }}\",\"rockspec\":\"launchdarkly-server-sdk-redis-${{ steps.manifest.outputs.version }}-0.rockspec\"}' >> $GITHUB_OUTPUT
           echo '}"' >> $GITHUB_OUTPUT
           echo 'EOF' >> $GITHUB_OUTPUT

release-please-config.json

@@ -6,7 +6,6 @@
       "versioning": "default",
       "extra-files": [
         "launchdarkly-server-sdk.c",
-        ".github/workflows/rockspec-info.yml",
         "README.md",
         "scripts/update-versions.sh",
         "scripts/compile.sh"