Address PR comments

Author: Dan Richelson

ldclient/interfaces.py

@@ -14,16 +14,17 @@ def get(self, key, callback):
         :param key: The feature key
         :type key: str
         :param callback: The function that accepts the feature data and returns the feature value
-        :type callback: function
-        :return: The feature value. None if not found
+        :type callback: Function that processes the feature flag once received.
+        :return: The result of executing callback.
         """
 
     @abstractmethod
     def all(self, callback):
         """
         Returns all feature flags and their data
-
-        :rtype: dict[str, dict]
+        :param callback: The function that accepts the feature data and returns the feature value
+        :type callback: Function that processes the feature flags once received.
+        :rtype: The result of executing callback.
         """
 
     @abstractmethod

ldclient/redis_feature_store.py

@@ -56,7 +56,7 @@ def all(self, callback):
                 results[f['key']] = f
         return callback(results)
 
-    def get(self, key, callback):
+    def get(self, key, callback=lambda x: x):
         f = self._cache.get(key)
         if f is not None:
             # reset ttl
@@ -112,7 +112,7 @@ def initialized(self):
     def upsert(self, key, feature):
         r = redis.Redis(connection_pool=self._pool)
         r.watch(self._features_key)
-        old = self.get(key, lambda x: x)
+        old = self.get(key)
         if old:
             if old['version'] >= feature['version']:
                 r.unwatch()

ldclient/twisted_client.py

@@ -35,8 +35,8 @@ def cb(result):
     def _evaluate_internal(self, flag, user):
         def check_prereq_results(result):
             prereq_ok = True
-            for r in result:  # r is a tuple of 2 booleans: (error, prereqMatches)
-                if r[0] is False or r[1] is False:
+            for (success, prereq_ok) in result:
+                if success is False or prereq_ok is False:
                     prereq_ok = False
 
             if prereq_ok is True:

ldclient/twisted_event_consumer.py

@@ -17,7 +17,7 @@ class TwistedEventConsumer(EventConsumer):
 
     def __init__(self, queue, sdk_key, config):
         self._queue = queue
-        """ @type: queue.Queue """
+        """ :type: queue.Queue """
 
         self._session = CacheControl(txrequests.Session())
         """ :type: txrequests.Session """