Skip to content

Commit a343458

Browse files
authored
chore: Remove frames.html from generated doc (#251)
The documentation generated from `yard` creates a [frames.html][1] file. This file is susceptible to XSS attacks. Additionally, this page can act as an open redirect (e.g. https://launchdarkly.github.io/ruby-server-sdk/frames.html#!////example.com). To remediate this problem, we are going to simply remove the generate frames.html file. This file was created to [support classical frameset views for the docs][2], which we have no need to support. [1]: https://github.com/lsegal/yard/blob/2d197a381c5d4cc5c55b2c60fff992b31c986361/templates/default/fulldoc/html/frames.erb [2]: lsegal/yard@dc0fcb4
1 parent 58e9d1f commit a343458

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

docs/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
ifeq ($(LD_RELEASE_VERSION),)
32
TITLE=LaunchDarkly Ruby SDK
43
else
@@ -20,6 +19,7 @@ html: dependencies
2019
lib/**/*.rb \
2120
lib/**/**/*.rb \
2221
lib/**/**/**/*.rb
22+
rm -f build/html/frames.html
2323

2424
dependencies:
2525
gem install --conservative yard

0 commit comments

Comments
 (0)