Merge pull request #38 from launchdarkly/eb/bucket-non-string

allow bucketing by int attribute (using its string representation)

Author: eli-darkly

lib/ldclient-rb/evaluation.rb

@@ -253,7 +253,10 @@ def variation_for_user(rule, user, flag)
     def bucket_user(user, key, bucket_by, salt)
       return nil unless user[:key]
 
-      id_hash = user_value(user, bucket_by)
+      id_hash = bucketable_string_value(user_value(user, bucket_by))
+      if id_hash.nil?
+        return 0.0
+      end
 
       if user[:secondary]
         id_hash += "." + user[:secondary]
@@ -265,6 +268,12 @@ def bucket_user(user, key, bucket_by, salt)
       hash_val.to_i(16) / Float(0xFFFFFFFFFFFFFFF)
     end
 
+    def bucketable_string_value(value)
+      return value if value.is_a? String
+      return value.to_s if value.is_a? Integer
+      nil
+    end
+
     def user_value(user, attribute)
       attribute = attribute.to_sym
 

spec/evaluation_spec.rb

@@ -127,4 +127,58 @@
       end
     end
   end
+
+  describe "bucket_user" do
+    it "gets expected bucket values for specific keys" do
+      user = { key: "userKeyA" }
+      bucket = bucket_user(user, "hashKey", "key", "saltyA")
+      expect(bucket).to be_within(0.0000001).of(0.42157587);
+
+      user = { key: "userKeyB" }
+      bucket = bucket_user(user, "hashKey", "key", "saltyA")
+      expect(bucket).to be_within(0.0000001).of(0.6708485);
+
+      user = { key: "userKeyC" }
+      bucket = bucket_user(user, "hashKey", "key", "saltyA")
+      expect(bucket).to be_within(0.0000001).of(0.10343106);
+    end
+
+    it "can bucket by int value (equivalent to string)" do
+      user = {
+        key: "userkey",
+        custom: {
+          stringAttr: "33333",
+          intAttr: 33333
+        }
+      }
+      stringResult = bucket_user(user, "hashKey", "stringAttr", "saltyA")
+      intResult = bucket_user(user, "hashKey", "intAttr", "saltyA")
+
+      expect(intResult).to be_within(0.0000001).of(0.54771423)
+      expect(intResult).to eq(stringResult)
+    end
+
+    it "cannot bucket by float value" do
+      user = {
+        key: "userkey",
+        custom: {
+          floatAttr: 33.5
+        }
+      }
+      result = bucket_user(user, "hashKey", "floatAttr", "saltyA")
+      expect(result).to eq(0.0)
+    end
+
+
+    it "cannot bucket by bool value" do
+      user = {
+        key: "userkey",
+        custom: {
+          boolAttr: true
+        }
+      }
+      result = bucket_user(user, "hashKey", "boolAttr", "saltyA")
+      expect(result).to eq(0.0)
+    end
+  end
 end