add: ciの追加 #8
Open
add: ciの追加 #8
+324
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R31K4G3
reviewed
Nov 21, 2025
|
.eslintrc.json と eslint.config.js があるけど，これって両方必要？ |
R31K4G3
reviewed
Nov 21, 2025
Author
.eslintrc.json消し忘れです |
- package.jsonのtype: moduleを削除（CommonJS出力のため不要） - @eslint/jsをdevDependenciesに追加 - 古い.eslintrc.jsonを削除 - eslint.config.jsをCommonJS形式に変更
- docker compose buildの成功を確認 - コンテナが正常に起動しDiscordログインまで到達することを確認 - TokenInvalidエラーが出ることで、コード自体は正常に動作していることを検証
- docker compose logsではなく、upの出力を直接ファイルに保存 - set +eでエラーを一時的に無視し、終了コードを取得 - ログを表示してデバッグしやすくする - grepの結果で成功/失敗を明示的に判定
Author
|
docker compose upを行い、コードが実行されるところまで確認するCIを追加しました |
R31K4G3
reviewed
Nov 21, 2025
|
TypeScript ESLint ，recommended よりも recommendedTypeChecked のほうが良いと思う。 |
- globalsパッケージをdevDependenciesに追加 - eslint.config.jsでglobals.nodeを使用 - 手動で定義していたNode.jsグローバル変数をglobalsパッケージに置き換え - NodeJSは個別に追加（globals.nodeに含まれていないため）
- tseslint.configs.recommendedからflat/recommended-type-checkedに変更 - より厳格な型チェックを有効化 - no-unused-varsを無効化してTypeScript ESLint版を優先
Author
|
やってみたー |
R31K4G3
reviewed
Nov 21, 2025
R31K4G3
reviewed
Nov 21, 2025
R31K4G3
reviewed
Nov 21, 2025
R31K4G3
requested changes
Nov 27, 2025
| "license": "ISC", | ||
| "devDependencies": { | ||
| "devDependencies": { | ||
| "@eslint/js": "^9.4.0", |
There was a problem hiding this comment.
別PRにするなら devDependencies の更新はしなくていいんじゃないすか
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
なぜやるのか
何をしたか
やらなかったこと
見てほしい点