Skip to content

Commit aa443f8

Browse files
committed
minor changes
1 parent 72450d4 commit aa443f8

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/resources/views/grid/filters/text.blade.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<input type="text" name="{{ $name }}" id="{{ $id }}"
22
form="{{ $formId }}"
3-
class="{{ $class }}" value="{{ request($name) }}" title="{{ $title }}" placeholder="{{ $titleSetOnColumn ?? $title }}"
3+
class="{{ $class }}" value="{{ request($name) }}" title="{{ $titleSetOnColumn ?? $title }}" placeholder="{{ $titleSetOnColumn ?? $title }}"
44
@foreach($dataAttributes as $k => $v)
55
data-{{ $k }}={{ $v }}
66
@endforeach

tests/PackageTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,10 +243,14 @@ public function grid_can_render_using_custom_layout()
243243
public function grid_can_add_custom_filter_titles()
244244
{
245245
$filterText = "filter-by-foo-bar";
246+
$existingFilterTextSampleNotExisting = "filter by name";
247+
$existingFilterTextSampleExisting = "filter by created_at";
246248
$grid = $this->getGridInstances()['users_customized'];
247249
/** @var $grid UsersGrid */
248250
$content = $grid->render();
249251

250252
$this->assertContains($filterText, $content);
253+
$this->assertContains($existingFilterTextSampleExisting, $content);
254+
$this->assertNotContains($existingFilterTextSampleNotExisting, $content);
251255
}
252256
}

0 commit comments

Comments
 (0)