Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .canvas
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
---
:lessons:
- :id: 73909
:course_id: 3297
:canvas_url: https://learning.flatironschool.com/courses/3297/assignments/73909
- :id: 223923
:course_id: 6638
:canvas_url: https://learning.flatironschool.com/courses/6638/assignments/223923
:type: assignment
- :id: 263276
:course_id: 7550
:canvas_url: https://learning.flatironschool.com/courses/7550/assignments/263276
:type: assignment
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: Sync with Canvas HTML
name: Sync with Canvas Ruby v2.7

on:
push:
branches: [master, main]
paths:
- "README.md"
- 'README.md'

jobs:
sync:
Expand All @@ -18,14 +18,14 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.6
ruby-version: 2.7

- name: Install github-to-canvas
run: gem install github-to-canvas

# Secret stored in learn-co-curriculum Settings/Secrets
- name: Sync from .canvas file
run: github-to-canvas -a -lr --forkable --contains-html
run: github-to-canvas -a -lr
env:
CANVAS_API_KEY: ${{ secrets.CANVAS_API_KEY }}
CANVAS_API_PATH: ${{ secrets.CANVAS_API_PATH }}
CANVAS_API_PATH: ${{ secrets.CANVAS_API_PATH }}
19 changes: 16 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,15 @@ the user experience by adding some custom greeting capabilities.

## Work Through Failing Tests in a JavaScript Test Suite

To start off, let's run the test suite with the `learn test` command. Our code
is currently failing all of the tests, but we expected that because we haven't
done anything yet. Let's get to work!
If you haven't already, fork and clone this lab into your local environment.
Remember to **fork** a copy into your GitHub account first, then **clone** from
that copy. Navigate into its directory in the terminal, then run `code .` to
open the files in Visual Studio Code.

Next, let's run `npm install` to install the dependencies then run the test
suite with the `npm test` command. Our code is currently failing all of the
tests, but we expected that because we haven't done anything yet. Let's get to
work!

### `currentUser`

Expand Down Expand Up @@ -409,6 +415,13 @@ const currentUser = 'Grace Hopper';
const shortGreeting = `Welcome, ${currentUser.slice(0, 1)}!`;
```

After you have all the tests passing, remember to commit and push your changes
up to GitHub, then submit your work to Canvas using CodeGrade. If you need a
reminder, go back to the [Completing and Submitting Assignments with
CodeGrade][completing-codegrade] lesson to review the process.

[completing-codegrade]: https://github.com/learn-co-curriculum/phase-1-completing-assignments-with-codegrade

Great work!

## Resources
Expand Down
5 changes: 4 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
// Write your code in this file!
let currentUser = 'Grace Hopper';
const welcomeMessage = 'Welcome to Flatbook, ' + currentUser + '!';
const excitedWelcomeMessage = welcomeMessage.toUpperCase();
const shortGreeting = `Welcome, ${currentUser.slice(0, 1)}!`;
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
"description": "JavaScript Strings Code-along for Learn.co",
"main": "index.js",
"scripts": {
"postinstall": "gem install learn-co",
"test": "mocha --timeout 5000 -R mocha-multi --reporter-options spec=-,json=.results.json"
},
"repository": {
Expand Down
2 changes: 2 additions & 0 deletions test/indexTest.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
require ( './helpers.js' );

describe('index.js', () => {
describe('currentUser', () => {
it('is defined', () => {
Expand Down