Skip to content

Improve daily mail #208

@TamaroWalter

Description

@TamaroWalter

The task to send the daily mails of unread moodleoverflow posts does not look pretty. I don't like 2 things:

  • The sender of the mail (it should be a no-reply dummy mail) has a long hash.
    Example: ?utf-8?B?QW50d29ydGVuIFNpZSBuaWNodCBhdWYgZGllc2UgRS1NYWlsICjDvGJlciA=?= =?utf-8?B?TGVhcm53ZWIp?= <noreply+learnweb@uni-muenster.de>
    The forum has an equal task but there the no-reply dummy mail is e.g. "Do not reply to this email (via Learnweb)" <noreply+learnweb@uni-muenster.de>. This version is a lot cleaner and beautiful to read.

Reproduction:
Reproducing this issue and showing screenshots is difficult due to the use of sensitive data.

Type of issue:
Improvement of existing feature.

Priority (1-6):
3

What files need to changed?

  • The task to send daily mails is in classes/task/send_daily_mail. This class needs to be improved. Maybe new language strings.
  • send_daily_mail has unit-test coverage. The existing tests need to be adapted to the improvement. New unit-tests are not likely to be necessary. Behat-test are not necessary.

Metadata

Metadata

Assignees

Labels

ImprovementImprove an existing feature/functionality

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions