Fix rendering new attributes, so that they dont render as dynamic. Fix adding new objectClasses to entries, need langtag to render the component

Author: leenooks

app/Classes/LDAP/Attribute/ObjectClass.php

@@ -6,6 +6,7 @@
 use Illuminate\Support\Collection;
 
 use App\Classes\LDAP\Attribute;
+use App\Ldap\Entry;
 
 /**
  * Represents an ObjectClass Attribute
@@ -74,6 +75,7 @@ public function render(bool $edit=FALSE,bool $old=FALSE,bool $new=FALSE): View
 		return view('components.attribute.objectclass')
 			->with('o',$this)
 			->with('edit',$edit)
+			->with('langtag',Entry::TAG_NOTAG)
 			->with('old',$old)
 			->with('new',$new);
 	}

app/Http/Controllers/APIController.php

@@ -97,7 +97,6 @@ public function schema_view(Request $request)
 	/**
 	 * Return the required and additional attributes for an object class
 	 *
-	 * @param Request $request
 	 * @param string $objectclass
 	 * @return array
 	 */

app/Http/Controllers/HomeController.php

@@ -93,11 +93,11 @@ public function entry_attr_add(Request $request,string $id): \Illuminate\View\Vi
 
 		return $request->noheader
 			? view(sprintf('components.attribute.widget.%s',$id))
-				->with('o',Factory::create($dn,$id,[],$request->objectclasses))
+				->with('o',Factory::create(dn: $dn,attribute: $id,values: [],oc: $request->objectclasses))
 				->with('value',$request->value)
 				->with('langtag',Entry::TAG_NOTAG)
 				->with('loop',$xx)
-			: new AttributeType(Factory::create($dn,$id,[],$request->objectclasses),TRUE)
+			: new AttributeType(Factory::create($dn,$id,[],$request->objectclasses),new: TRUE,edit: TRUE)
 				->render();
 	}
 

app/View/Components/Attribute.php

@@ -2,6 +2,8 @@
 
 namespace App\View\Components;
 
+use Closure;
+use Illuminate\Contracts\View\View;
 use Illuminate\View\Component;
 
 use App\Classes\LDAP\Attribute as LDAPAttribute;
@@ -32,13 +34,13 @@ public function __construct(?LDAPAttribute $o,bool $edit=FALSE,bool $old=FALSE,b
 	/**
 	 * Get the view / contents that represent the component.
 	 *
-	 * @return \Illuminate\Contracts\View\View|\Closure|string
+	 * @return View|string
 	 */
-	public function render()
+	public function render(): View|string
 	{
 		return $this->o
 			? $this->o
-				->render($this->edit,$this->old,$this->new)
+				->render(edit: $this->edit,old: $this->old,new: $this->new)
 			: $this->na;
 	}
 }

app/View/Components/AttributeType.php

@@ -2,7 +2,6 @@
 
 namespace App\View\Components;
 
-use Closure;
 use Illuminate\Contracts\View\View;
 use Illuminate\View\Component;
 
@@ -30,7 +29,7 @@ public function __construct(LDAPAttribute $o,bool $new=FALSE,bool $edit=FALSE,st
 	/**
 	 * Get the view / contents that represent the component.
 	 */
-	public function render(): View|Closure|string
+	public function render(): View
 	{
 		return view('components.attribute-type')
 			->with('o',$this->o)

resources/views/components/attribute/widget/options.blade.php

@@ -46,6 +46,9 @@ function process_oc() {
 									if (added_oc.indexOf(item) !== -1)
 										return;
 
+									// Add our new OC to the list of OCs
+									oc.push(item);
+
 									// Add attribute to the page
 									$.ajax({
 										method: 'POST',
@@ -146,7 +149,7 @@ function process_oc() {
 														if (x.length) {
 															x.remove();
 
-															// Add this to the must attrs list, because its been rendered
+														// Add this to the must attrs list, because its been rendered
 														} else {
 															attrs.push(mayitem);
 														}