Commit 792de22
Check error return of rows.Close(). (#6)
According to
https://github.blog/2020-05-20-three-bugs-in-the-go-mysql-driver/, when
QueryContext is called with a context that is cancelled during scan, you
can receive incomplete or corrupted results. As I understand it, the
corruption is fixed upstream, but it's still possible to get incomplete
results that will only show up in the error result from Close.
It's still possible and correct to call `defer rows.Close()`, since the
database/sql docs say this:
https://godoc.org/database/sql#Rows.Close
> Close is idempotent and does not affect the result of Err.
Note: This is a recreation of go-gorp#420
Co-authored-by: Jacob Hoffman-Andrews <github@hoffman-andrews.com>1 parent a4dac79 commit 792de22
1 file changed
+11
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
168 | 168 | | |
169 | 169 | | |
170 | 170 | | |
171 | | - | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
172 | 177 | | |
173 | 178 | | |
174 | 179 | | |
| |||
351 | 356 | | |
352 | 357 | | |
353 | 358 | | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
354 | 364 | | |
355 | 365 | | |
356 | 366 | | |
| |||
0 commit comments