Skip to content

Conversation

@lalitcap23
Copy link

@lalitcap23 lalitcap23 commented Nov 25, 2025

Summary

Adds closeRead and reset behavior tests to the stream muxer compliance test suite.

Changes

  • Added closes read only test to compliance suite
  • Added resets when remote aborts test to compliance suite

Why

These tests validate generic stream behavior (half-closing and reset handling) that should be consistent across all stream muxer implementations (Yamux, Mplex, etc.), not just WebRTC.
Adding them to the compliance suite ensures all implementations handle these cases correctly.

Testing

The tests follow the same style as the existing ones and work directly with the generic Stream interface.
Fixes #3360

@lalitcap23 lalitcap23 requested a review from a team as a code owner November 25, 2025 11:56
@tabcat
Copy link
Contributor

tabcat commented Nov 29, 2025

These tests shouldn't just be copied over, they should be adapted to fit with the tests they are being moved into. Be sure to only add test coverage, something covered in the previous tests and missing in the new ones. It looks like some of the copied tests were already covered. Be sure to identify what coverage is missing, if any, and add it to an existing or new test.

After that remove the currently skipped portions from the webrtc stream tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move WebRTC stream timeline and flag handling tests to interface compliance suite for all transports

2 participants