Feature transformations (#188)

* light-curve-feature 0.5.4 -> 0.5.5

* Init impl of tranform=None

* Downgrade enum-iterator for MSRV

* Changelog

* Reimpl default transformer

* Revert "Downgrade enum-iterator for MSRV"

We require MSRV 1.62 instead of 1.60

This reverts commit b899278.

* Python 3.7 compat

* More Python 3.7 compat

Author: hombit

CHANGELOG.md

@@ -9,12 +9,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
+- Feature transformations via `transoform` constructor keyword. For most of the features it could accept string with a transformation name such as 'arcsinh' or 'clipped_lg', `True` or 'default' for the default transformation, `None` or `False` for no transformation https://github.com/light-curve/light-curve-python/issues/184 https://github.com/light-curve/light-curve-python/pull/188
 - Binary wheels for x86_64 Windows built with no Ceres nor GSL features https://github.com/light-curve/light-curve-python/issues/12 https://github.com/light-curve/light-curve-python/pull/185
+- `enum-iterator` crate dependency https://github.com/light-curve/light-curve-python/pull/188
 - CI: code coverage with `codecov` https://github.com/light-curve/light-curve-python/pull/197
 - Development: now project has extras for testing (`test`) and development (`dev`) https://github.com/light-curve/light-curve-python/pull/197
 
 ### Changed
 
+- **Build breaking**: minimum supported Rust version (MSRV) is bump from 1.60 to 1.62
+- Bump `light-curve-feature` 0.5.4 -> 0.5.5
 - Bump `pyO3` 0.18.1 -> 0.18.2
 - Most of the parametric features have default values for their parameters now, which, due to `pyO3` limitations, are not presented in the signatures, but documented in the docstrings. It also makes Python and Rust implementations more consistent https://github.com/light-curve/light-curve-python/issues/194 https://github.com/light-curve/light-curve-python/pull/195
 - Development: switch from `pytest-markdown` to `markdown-pytest` which allowed us to use up-to-date pytest https://github.com/light-curve/light-curve-python/pull/198
@@ -30,7 +34,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
---
+- `Bins` feature had non-optimal lower boundary check for time series length: it checked if it is at least unity for any underlying features. Now it takes underlying feature requirements into account. It was fixed by updating `light-curve-feature` to v0.5.5.
 
 ### Security
 

light-curve/Cargo.lock

@@ -7,7 +7,7 @@ readme = "README.md"
 repository = "https://github.com/light-curve/light-curve-python"
 license = "GPL-3.0-or-later"
 edition = "2021"
-rust-version = "1.60"
+rust-version = "1.62"
 
 [lib]
 name = "light_curve"
@@ -32,14 +32,15 @@ gsl = ["light-curve-feature/gsl"]
 anyhow = "<1.0.49"
 const_format = "0.2.30"
 conv = "0.3.3"
+enum-iterator = "1.1.0,<1.2.0" # 1.2.0 requires MSRV 1.63
 enumflags2 = { version = "0.7.5", features = ["serde"] }
 itertools = "0.10.5"
 macro_const = "0.1.0"
 ndarray = { version = "0.15.3", features = ["rayon"] }
 numpy = "0.18.0"
 num_cpus = "1.13.0"
 num-traits = "0.2"
-pyo3 = {version = "0.18.2", features = ["extension-module"]}
+pyo3 = {version = "0.18.2", features = ["extension-module", "multiple-pymethods"]}
 rand = "0.8.5"
 rand_xoshiro = "0.6.0"
 thiserror = "1.0.37"
@@ -53,5 +54,5 @@ version = "0.7.1"
 features = ["serde"]
 
 [dependencies.light-curve-feature]
-version = "0.5.4"
+version = "0.5.5"
 default_features = false

light-curve/Cargo.toml

@@ -11,7 +11,7 @@ import_exception!(pickle, PicklingError);
 import_exception!(pickle, UnpicklingError);
 
 #[allow(clippy::enum_variant_names)]
-#[derive(Clone, Error, Debug)]
+#[derive(Error, Debug)]
 #[error("{0}")]
 pub(crate) enum Exception {
     // builtins
@@ -23,6 +23,8 @@ pub(crate) enum Exception {
     // pickle
     PicklingError(String),
     UnpicklingError(String),
+    // some exception from pyo3 which we need to handle
+    PyO3(#[from] PyErr),
 }
 
 impl From<Exception> for PyErr {
@@ -37,6 +39,8 @@ impl From<Exception> for PyErr {
             // pickle
             Exception::PicklingError(err) => PicklingError::new_err(err),
             Exception::UnpicklingError(err) => UnpicklingError::new_err(err),
+            // pyo3
+            Exception::PyO3(err) => err,
         }
     }
 }