feedsToCheck Appears to Only Check One Feed Per Station

[penniesfromheaven]

I'm trying to identify trains running on two lines, the A/C and B/D, arriving at Columbus Circle, station A24. The code, however, only returns the trains arriving on the B/D line, which are associated with feedsToCheck = BDFMfeednum. If I put ACEHfeednum ahead of BDFMfeednum, the code returns the trains arriving on the A/C line, but not the B/D line. I can't seem to get the code to return the trains running on both lines.

Any help would be greatly appreciated.

[lightalan]

I'm not quite sure how to resolve this, as it is not simply a matter of checking multiple feeds. The UI is designed to only display a single train line in each direction. To support what you want would require re-working the UI code to a significant degree. Let me think about it.

…

On Mon, Dec 2, 2019, 10:25 PM penniesfromheaven ***@***.***> wrote: I'm trying to identify trains running on two lines, the A/C and B/D, arriving at Columbus Circle, station A24. The code, however, only returns the trains arriving on the B/D line, which are associated with feedsToCheck = BDFMfeednum. If I put ACEHfeednum ahead of BDFMfeednum, the code returns the trains arriving on the A/C line, but not the B/D line. I can't seem to get the code to return the trains running on both lines. Any help would be greatly appreciated. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5?email_source=notifications&email_token=AK7LEUZRRQZHUZUGJ7X4G7LQWXGRTA5CNFSM4JURGQMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H5Q5YDA>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AK7LEU2FIY5KKEJEZ4DWOCDQWXGRTANCNFSM4JURGQMA> .

[penniesfromheaven]

Much appreciated. I'm using the returned times to drive LEDs attached to a Pi, rather than use the full UI, so at least for me, it would help even if it's something that was initially supported only in the backend code.

[lightalan]

Ahhh that changes everything. That will be EZ. I'll work on it this weekend.

…

On Tue, Dec 3, 2019, 2:53 PM penniesfromheaven ***@***.***> wrote: Much appreciated. I'm using the returned times to drive LEDs attached to a Pi, rather than use the full UI, so at least for me, it would help even if it's something that was initially supported only in the backend code. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5?email_source=notifications&email_token=AK7LEUYLWCDZLTGY6CVVANLQW22J3A5CNFSM4JURGQMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF2TKIA#issuecomment-561329440>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AK7LEU6YOIGFOLRFOFLAGLDQW22J3ANCNFSM4JURGQMA> .

[penniesfromheaven]

Thanks again for looking at this - any update?

[lightalan]

Sorry, I got real busy at work, but I'm on vacation for the next two weeks, so I'm sure I'll get to it before the year ends.

…

On Sun, Dec 22, 2019, 5:33 PM penniesfromheaven ***@***.***> wrote: Thanks again for looking at this - any update? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5?email_source=notifications&email_token=AK7LEUYNHJIPA7CCEIMPH4DQZ7TLRA5CNFSM4JURGQMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHP3G5Y#issuecomment-568308599>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AK7LEU3MWBRWXNWA6BAUSSLQZ7TLRANCNFSM4JURGQMA> .

[penniesfromheaven]

Any sense when this might be implemented?

[lightalan]

Sorry, got sidetracked with family... Will get to it, I didn't forget.

…

On Thu, Feb 6, 2020, 8:25 PM penniesfromheaven ***@***.***> wrote: Any sense when this might be implemented? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5?email_source=notifications&email_token=AK7LEU6FOCY55PSRYAGCWE3RBS2BDA5CNFSM4JURGQMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELBMVSI#issuecomment-583191241>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AK7LEU45GXPVZAFFDEWLLMTRBS2BDANCNFSM4JURGQMA> .

[penniesfromheaven]

Sounds good, thanks again.

[penniesfromheaven]

Any progress? I think you just need to add a loop to run for as many entries are populated in feedsToCheck but they way the code is structured I'm not quite sure where the loop would go. It looks like it's meant to work with feedScores, but because only the first entry with a hit in feedsToCheck returns any values, feedScores for any other entries always appear to return 0.

[lightalan]

Yikes, sorry but I TOTALLY forgot about this. (I had to rush out a change to support the new MTA API, and that would have been a good time to tackle this). I'll take a look at this, but if memory serves me correctly from the last time I looked at this, the approach was going to be to add an optional flag which would check every feed, every time. Sorry again.

…

On Fri, Aug 7, 2020 at 9:43 PM penniesfromheaven ***@***.***> wrote: Any progress? I think you just need to add a loop to run for as many entries are populated in feedsToCheck but they way the code is structured I'm not quite sure where the loop would go. It looks like it's meant to work with feedScores, but because only the first entry with a hit in feedsToCheck returns any values, feedScores for any other entries always appear to return 0. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AK7LEU2XCFFY4K337325QMDR7SUU5ANCNFSM4JURGQMA> .

[penniesfromheaven]

No worries at all. An optional flag sounds great.