From 4c229baae39902d78f5df1862c8427703a7f2709 Mon Sep 17 00:00:00 2001 From: Jeevan Pillay <169354619+jeevanpillay@users.noreply.github.com> Date: Wed, 6 May 2026 22:48:53 +1000 Subject: [PATCH] fix(desktop): set MakerDeb/MakerRpm bin to lightfast MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Linux makers default `options.bin` to `pkg.name` (via electron-installer-common's getDefaultsFromPackageJSON). After the release workflow runs `npm version`, that value is `@lightfast/desktop` — the package's npm name, not the executable name. The actual binary on disk is `lightfast`, set via `packagerConfig.executableName`. Without an explicit override, both makers fail at the binary-symlink step: could not find the Electron app binary at ".../Lightfast-linux-x64/@lightfast/desktop" Set `options.bin: "lightfast"` on both MakerDeb and MakerRpm. Surfaced by the @lightfast/desktop@0.1.0-rc.5 dry-run; mac legs were unaffected. --- apps/desktop/forge.config.ts | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/apps/desktop/forge.config.ts b/apps/desktop/forge.config.ts index 317156e00..c911fb26a 100644 --- a/apps/desktop/forge.config.ts +++ b/apps/desktop/forge.config.ts @@ -155,6 +155,13 @@ const config: ForgeConfig = { { options: { name: "lightfast", + // electron-installer-common defaults `bin` to `pkg.name`, which + // becomes `@lightfast/desktop` after the release workflow runs + // `npm version`. The actual binary on disk is `lightfast` (set via + // `packagerConfig.executableName` above). Without this override the + // maker fails: "could not find the Electron app binary at + // .../Lightfast-linux-/@lightfast/desktop". + bin: "lightfast", productName: "Lightfast", genericName: "Developer Tool", maintainer: "Lightfast ", @@ -169,6 +176,9 @@ const config: ForgeConfig = { { options: { name: "lightfast", + // Same `bin` override as MakerDeb above — electron-installer-redhat + // shares the same `getDefaultsFromPackageJSON` helper. + bin: "lightfast", productName: "Lightfast", genericName: "Developer Tool", license: "MIT",