Switch to use rustls-ring everywhere

We switch to use `rustls-ring` everywhere, which is necessary
for Swift builds, but also generally makes our lives easier.

Author: tnull

.github/workflows/kotlin.yml

@@ -39,9 +39,6 @@ jobs:
       - name: Generate Kotlin JVM
         run: ./scripts/uniffi_bindgen_generate_kotlin.sh
 
-      - name: Install `bindgen-cli`
-        run: cargo install --force bindgen-cli
-
       - name: Generate Kotlin Android
         run: ./scripts/uniffi_bindgen_generate_kotlin_android.sh
 

Cargo.toml

@@ -36,7 +36,7 @@ default = []
 #lightning-background-processor = { version = "0.1.0" }
 #lightning-rapid-gossip-sync = { version = "0.1.0" }
 #lightning-block-sync = { version = "0.1.0", features = ["rest-client", "rpc-client", "tokio"] }
-#lightning-transaction-sync = { version = "0.1.0", features = ["esplora-async-https", "time", "electrum"] }
+#lightning-transaction-sync = { version = "0.1.0", features = ["esplora-async-https", "time", "electrum-rustls-ring"] }
 #lightning-liquidity = { version = "0.1.0", features = ["std"] }
 #lightning-macros = { version = "0.1.0" }
 
@@ -48,7 +48,7 @@ default = []
 #lightning-background-processor = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main" }
 #lightning-rapid-gossip-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main" }
 #lightning-block-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["rest-client", "rpc-client", "tokio"] }
-#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "electrum", "time"] }
+#lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main", features = ["esplora-async-https", "electrum-rustls-ring", "time"] }
 #lightning-liquidity = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main" }
 #lightning-macros = { git = "https://github.com/lightningdevkit/rust-lightning", branch = "main" }
 
@@ -60,7 +60,7 @@ lightning-persister = { git = "https://github.com/lightningdevkit/rust-lightning
 lightning-background-processor = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "e1a31e1b6a55056a039c693246a5636957ed7a54" }
 lightning-rapid-gossip-sync = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "e1a31e1b6a55056a039c693246a5636957ed7a54" }
 lightning-block-sync = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "e1a31e1b6a55056a039c693246a5636957ed7a54", features = ["rest-client", "rpc-client", "tokio"] }
-lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "e1a31e1b6a55056a039c693246a5636957ed7a54", features = ["esplora-async-https", "electrum", "time"] }
+lightning-transaction-sync = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "e1a31e1b6a55056a039c693246a5636957ed7a54", features = ["esplora-async-https", "electrum-rustls-ring", "time"] }
 lightning-liquidity = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "e1a31e1b6a55056a039c693246a5636957ed7a54" }
 lightning-macros = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "e1a31e1b6a55056a039c693246a5636957ed7a54" }
 
@@ -78,7 +78,7 @@ lightning-macros = { git = "https://github.com/lightningdevkit/rust-lightning",
 
 bdk_chain = { version = "0.23.0", default-features = false, features = ["std"] }
 bdk_esplora = { version = "0.22.0", default-features = false, features = ["async-https-rustls", "tokio"]}
-bdk_electrum = { version = "0.23.0", default-features = false, features = ["use-rustls"]}
+bdk_electrum = { version = "0.23.0", default-features = false, features = ["use-rustls-ring"]}
 bdk_wallet = { version = "2.0.0", default-features = false, features = ["std", "keys-bip39"]}
 
 reqwest = { version = "0.12", default-features = false, features = ["json", "rustls-tls"] }
@@ -93,7 +93,7 @@ rand = "0.8.5"
 chrono = { version = "0.4", default-features = false, features = ["clock"] }
 tokio = { version = "1.37", default-features = false, features = [ "rt-multi-thread", "time", "sync", "macros" ] }
 esplora-client = { version = "0.12", default-features = false, features = ["tokio", "async-https-rustls"] }
-electrum-client = { version = "0.24.0", default-features = true }
+electrum-client = { version = "0.24.0", default-features = false, features = ["proxy", "use-rustls-ring"] }
 libc = "0.2"
 uniffi = { version = "0.28.3", features = ["build"], optional = true }
 serde = { version = "1.0.210", default-features = false, features = ["std", "derive"] }

src/builder.rs

@@ -1689,7 +1689,7 @@ fn optionally_install_rustls_cryptoprovider() {
 	INIT_CRYPTO.call_once(|| {
 		// Ensure we always install a `CryptoProvider` for `rustls` if it was somehow not previously installed by now.
 		if rustls::crypto::CryptoProvider::get_default().is_none() {
-			let _ = rustls::crypto::aws_lc_rs::default_provider().install_default();
+			let _ = rustls::crypto::ring::default_provider().install_default();
 		}
 
 		// Refuse to startup without TLS support. Better to catch it now than even later at runtime.