f Also avoid allocating error messages when not panicking

Author: tnull

src/io/sqlite_store.rs

@@ -29,21 +29,21 @@ pub struct SqliteStore {
 
 impl SqliteStore {
 	pub(crate) fn new(dest_dir: PathBuf) -> Self {
-		let msg =
-			format!("Failed to create database destination directory: {}", dest_dir.display());
-		fs::create_dir_all(dest_dir.clone()).expect(&msg);
+		fs::create_dir_all(dest_dir.clone()).unwrap_or_else(|_| {
+			panic!("Failed to create database destination directory: {}", dest_dir.display())
+		});
 		let mut db_file_path = dest_dir.clone();
 		db_file_path.push(SQLITE_DB_FILE);
 
-		let msg = format!("Failed to open/create database file: {}", db_file_path.display());
-		let connection = Connection::open(db_file_path).expect(&msg);
+		let connection = Connection::open(db_file_path.clone()).unwrap_or_else(|_| {
+			panic!("Failed to open/create database file: {}", db_file_path.display())
+		});
 
-		let msg = format!("Failed to set PRAGMA user_version");
 		connection
 			.pragma(Some(rusqlite::DatabaseName::Main), "user_version", SCHEMA_USER_VERSION, |_| {
 				Ok(())
 			})
-			.expect(&msg);
+			.unwrap_or_else(|_| panic!("Failed to set PRAGMA user_version"));
 
 		let sql = format!(
 			"CREATE TABLE IF NOT EXISTS {} (
@@ -53,8 +53,9 @@ impl SqliteStore {
 		);",
 			KV_TABLE_NAME
 		);
-		let msg = format!("Failed to create table: {}", KV_TABLE_NAME);
-		connection.execute(&sql, []).expect(&msg);
+		connection
+			.execute(&sql, [])
+			.unwrap_or_else(|_| panic!("Failed to create table: {}", KV_TABLE_NAME));
 
 		let connection = Arc::new(Mutex::new(connection));
 		Self { connection }