Remove transaction dependency in invoice action

since wallet balances are polled now and
transactions are updated anyway when navigating
to the transaction list

Author: tanx

src/action/index.js

@@ -38,14 +38,7 @@ export const wallet = new WalletAction(store, grpc, db, nav, notify);
 export const info = new InfoAction(store, grpc, nav, notify);
 export const transaction = new TransactionAction(store, grpc, nav);
 export const channel = new ChannelAction(store, grpc, transaction, nav, notify);
-export const invoice = new InvoiceAction(
-  store,
-  grpc,
-  transaction,
-  nav,
-  notify,
-  Clipboard
-);
+export const invoice = new InvoiceAction(store, grpc, nav, notify, Clipboard);
 export const payment = new PaymentAction(store, grpc, transaction, nav, notify);
 export const setting = new SettingAction(store, wallet, db, ipc);
 

src/action/invoice.js

@@ -7,10 +7,9 @@ import { PREFIX_URI } from '../config';
 import { toSatoshis } from '../helper';
 
 class InvoiceAction {
-  constructor(store, grpc, transaction, nav, notification, clipboard) {
+  constructor(store, grpc, nav, notification, clipboard) {
     this._store = store;
     this._grpc = grpc;
-    this._transaction = transaction;
     this._nav = nav;
     this._notification = notification;
     this._clipboard = clipboard;
@@ -70,7 +69,6 @@ class InvoiceAction {
     } catch (err) {
       this._notification.display({ msg: 'Creating invoice failed!', err });
     }
-    await this._transaction.update();
   }
 
   /**

stories/screen.js

@@ -67,14 +67,7 @@ sinon.stub(wallet, 'checkPassword');
 sinon.stub(wallet, 'getExchangeRate');
 const transaction = new TransactionAction(store, grpc, nav);
 sinon.stub(transaction, 'update');
-const invoice = new InvoiceAction(
-  store,
-  grpc,
-  transaction,
-  nav,
-  notify,
-  Clipboard
-);
+const invoice = new InvoiceAction(store, grpc, nav, notify, Clipboard);
 sinon.stub(invoice, 'generateUri');
 const payment = new PaymentAction(store, grpc, transaction, nav, notify);
 sinon.stub(payment, 'checkType');

test/integration/action/action-integration.spec.js

@@ -151,7 +151,7 @@ describe('Action Integration Tests', function() {
     wallet1 = new WalletAction(store1, grpc1, db1, nav1, notify1);
     transactions1 = new TransactionAction(store1, grpc1, nav1);
     channels1 = new ChannelAction(store1, grpc1, transactions1, nav1, notify1);
-    invoice1 = new InvoiceAction(store1, grpc1, transactions1, nav1, notify1);
+    invoice1 = new InvoiceAction(store1, grpc1, nav1, notify1);
     payments1 = new PaymentAction(store1, grpc1, transactions1, nav1, notify1);
 
     db2 = sinon.createStubInstance(AppStorage);
@@ -163,7 +163,7 @@ describe('Action Integration Tests', function() {
     wallet2 = new WalletAction(store2, grpc2, db2, nav2, notify2);
     transactions2 = new TransactionAction(store2, grpc2, nav2);
     channels2 = new ChannelAction(store2, grpc2, transactions2, nav2, notify2);
-    invoice2 = new InvoiceAction(store2, grpc2, transactions2, nav2, notify2);
+    invoice2 = new InvoiceAction(store2, grpc2, nav2, notify2);
     payments2 = new PaymentAction(store2, grpc2, transactions2, nav2, notify2);
   });
 

test/unit/action/invoice.spec.js

@@ -2,15 +2,13 @@ import { Store } from '../../../src/store';
 import NavAction from '../../../src/action/nav';
 import GrpcAction from '../../../src/action/grpc';
 import InvoiceAction from '../../../src/action/invoice';
-import TransactionAction from '../../../src/action/transaction';
 import NotificationAction from '../../../src/action/notification';
 
 describe('Action Invoice Unit Tests', () => {
   let store;
   let nav;
   let grpc;
   let invoice;
-  let transaction;
   let notification;
   let clipboard;
 
@@ -22,15 +20,7 @@ describe('Action Invoice Unit Tests', () => {
     grpc = sinon.createStubInstance(GrpcAction);
     notification = sinon.createStubInstance(NotificationAction);
     clipboard = { setString: sinon.stub() };
-    transaction = sinon.createStubInstance(TransactionAction);
-    invoice = new InvoiceAction(
-      store,
-      grpc,
-      transaction,
-      nav,
-      notification,
-      clipboard
-    );
+    invoice = new InvoiceAction(store, grpc, nav, notification, clipboard);
   });
 
   describe('init()', () => {
@@ -78,7 +68,6 @@ describe('Action Invoice Unit Tests', () => {
       expect(store.invoice.encoded, 'to equal', 'some-request');
       expect(store.invoice.uri, 'to equal', 'lightning:some-request');
       expect(nav.goInvoiceQR, 'was called once');
-      expect(transaction.update, 'was called once');
     });
 
     it('should display notification on error', async () => {