Handle error for getNetworkInfo grpc api call

Author: tanx

src/action/info.js

@@ -16,6 +16,20 @@ class InfoAction {
     this._notification = notification;
   }
 
+  /**
+   * Fetch the network info e.g. number of node in the channel graph as a
+   * proxy for filter header syncing being completed.
+   * @return {Promise<undefined>}
+   */
+  async getNetworkInfo() {
+    try {
+      const response = await this._grpc.sendCommand('getNetworkInfo');
+      this._store.numNodes = response.num_nodes;
+    } catch (err) {
+      log.error('Getting network info failed', err);
+    }
+  }
+
   /**
    * Fetches the current details of the lnd node and sets the corresponding
    * store parameters. This api is polled at the beginning of app initialization
@@ -31,8 +45,9 @@ class InfoAction {
       this._store.pubKey = response.identity_pubkey;
       this._store.syncedToChain = response.synced_to_chain;
       this._store.blockHeight = response.block_height;
-      const netRes = await this._grpc.sendCommand('getNetworkInfo');
-      this._store.isSyncing = !response.synced_to_chain || netRes.num_nodes < 2;
+      await this.getNetworkInfo();
+      this._store.isSyncing =
+        !response.synced_to_chain || this._store.numNodes < 2;
       if (this.startingSyncTimestamp === undefined) {
         this.startingSyncTimestamp = response.best_header_timestamp || 0;
       }
@@ -41,7 +56,7 @@ class InfoAction {
         log.info(
           `Syncing to chain ...`,
           `block height: ${response.block_height}`,
-          `num nodes: ${netRes.num_nodes}`
+          `num nodes: ${this._store.numNodes}`
         );
         this._store.percentSynced = this.calcPercentSynced(response);
       }

src/store.js

@@ -29,6 +29,7 @@ export class Store {
       percentSynced: 0, // Expects 0-1 range
       route: DEFAULT_ROUTE,
       blockHeight: null,
+      numNodes: null,
       balanceSatoshis: 0,
       confirmedBalanceSatoshis: 0,
       unconfirmedBalanceSatoshis: 0,

test/unit/action/info.spec.js

@@ -29,6 +29,22 @@ describe('Action Info Unit Tests', () => {
     sandbox.restore();
   });
 
+  describe('getNetworkInfo()', () => {
+    it('should set number of nodes', async () => {
+      grpc.sendCommand.withArgs('getNetworkInfo').resolves({
+        num_nodes: 2,
+      });
+      await info.getNetworkInfo();
+      expect(store.numNodes, 'to equal', 2);
+    });
+
+    it('should log error on failure', async () => {
+      grpc.sendCommand.rejects();
+      await info.getNetworkInfo();
+      expect(logger.error, 'was called once');
+    });
+  });
+
   describe('getInfo()', () => {
     it('should get public key, synced to chain, and block height', async () => {
       grpc.sendCommand.withArgs('getInfo').resolves({
@@ -57,6 +73,16 @@ describe('Action Info Unit Tests', () => {
       expect(synced, 'to be', true);
     });
 
+    it('should return false if chain is synced network info failed', async () => {
+      grpc.sendCommand.withArgs('getInfo').resolves({
+        synced_to_chain: true,
+      });
+      grpc.sendCommand.withArgs('getNetworkInfo').rejects(new Error('Boom!'));
+      const synced = await info.getInfo();
+      expect(synced, 'to be', false);
+      expect(logger.error, 'was called once');
+    });
+
     it('should return false if chain is synced but not filter headers', async () => {
       grpc.sendCommand.withArgs('getInfo').resolves({
         synced_to_chain: true,