Handle fresh install with no stored settings

Author: tanx

src/action/app-storage.js

@@ -9,17 +9,17 @@ class AppStorage {
   async restore() {
     try {
       const stateString = await this._AsyncStorage.getItem('settings');
+      if (!stateString) return;
       const state = JSON.parse(stateString);
-      state &&
-        Object.keys(state).forEach(key => {
-          if (typeof this._store.settings[key] !== 'undefined') {
-            this._store.settings[key] = state[key];
-          }
-        });
-      log.info('Loaded initial state');
-      this._store.loaded = true;
+      Object.keys(state).forEach(key => {
+        if (typeof this._store.settings[key] !== 'undefined') {
+          this._store.settings[key] = state[key];
+        }
+      });
     } catch (err) {
       log.error('Store load error', err);
+    } finally {
+      log.info('Loaded initial state');
       this._store.loaded = true;
     }
   }

test/unit/action/app-storage.spec.js

@@ -25,6 +25,14 @@ describe('Action App Storage Unit Tests', () => {
   });
 
   describe('restore()', () => {
+    it('should use default if nothing is saved yet', async () => {
+      AsyncStorageStub.getItem.resolves(undefined);
+      await db.restore(AsyncStorageStub);
+      expect(store.settings.unit, 'to equal', 'btc');
+      expect(logger.error, 'was not called');
+      expect(store.loaded, 'to be', true);
+    });
+
     it('should set supported setting', async () => {
       AsyncStorageStub.getItem
         .withArgs('settings')