-
Notifications
You must be signed in to change notification settings - Fork 64
Description
Parley Draw currently depends on vello_common for the Pixmap type. It uses this as a representation for bitmap data (including in the public API), and also for reading PNG files.
This is not ideal as it couples parley_draw version to specific vello versions. Which will mean publishing a new version of parley_draw every time we publish vello (sparse strips), and also make it awkward to use parley_draw with main-branch versions of vello.
I can think of a few ways to eliminate this dependency:
- Duplicate (copy-paste)
Pixmapintoparley_draw - Include a simplified version of
Pixmapinparley_draw - Move
Pixmapinto a shared crate (peniko? a new crate?) - Use simple types (e.g.
Vec<u8>) to represent bitmap data inparley_draw
What do other people think the best way to deal with this is? (CC: @grebmeg @valadaptive @taj-p @LaurenzV)
Note: Parley Draw also pulls in vello_common as part of vello_cpu when that feature is enabled. But that dependency is optional and doesn't impact anyone who doesn't have the vello_cpu feature enabled (and therefore not problematic in my opinion).