Skip to content

Conversation

@j-zimnowoda
Copy link
Contributor

@j-zimnowoda j-zimnowoda commented Oct 29, 2025

📌 Summary

  • Upgrade argocd-image-updater
  • Deploy workloads as Application instead of ApplicationsSets, so they are immediately visible in ArgoCD dashboard.
  • Set argocd-application-image-updater to store updated tags in the values repo instead of the charts repo to adhere to the single source of truth rule.
  • Get rid of the additional values property.

depends-on: linode/apl-api#832

🔍 Reviewer Notes

  • This change leverages multiple Application sources instead of single source, so there are two values files for a given workload. One that is managed by user and the other that is managed by the argocd-application-image-updater
  • The values are migrated automatically.
  • upgrade script removes ApplicationSets without impacting Applications.
  • user will be instructed to migrate content of k8s-deployment/.argocd-source-<team-name>-<workload-name>.yaml from charts repo to corresponding env/teams//workloads/.managed.yaml file and to delete the .argocd-source-<team-name>-<workload-name>.yaml

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

@Ani1357
Copy link
Contributor

Ani1357 commented Nov 12, 2025

Tested by upgrading existing cluster with running workloads. After the upgrade,the existing workload gets converted as expected in an application with 2 sources (values repo and charts repo) but since the old image sha was already saved in the charts repo, the image tag never gets updated. Deleting the k8s-deployment/.argocd-source-team-demo-<workload-name>.yaml solves it.

@j-zimnowoda
Copy link
Contributor Author

j-zimnowoda commented Nov 13, 2025

Deleting the k8s-deployment/.argocd-source-team-demo-<workload-name>.yaml solves it.

Great finding! Thanks you.
For this use case I propose to add the upgrade instructions.

@j-zimnowoda j-zimnowoda enabled auto-merge (squash) November 14, 2025 15:23
@j-zimnowoda j-zimnowoda disabled auto-merge November 14, 2025 15:26
@j-zimnowoda j-zimnowoda merged commit cef74c2 into main Nov 14, 2025
12 checks passed
@j-zimnowoda j-zimnowoda deleted the APL-1195-1 branch November 14, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants