-
Notifications
You must be signed in to change notification settings - Fork 55
fix: add DTK preference override configuration #1387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Added installation of override configuration files in debian/dde- shell.install 2. Updated CMakeLists.txt to install DTK preference override configuration 3. Created new override file shell/overrides/ org.deepin.dtk.preference.json 4. The override file defines themeType configuration with proper metadata including Chinese translations Log: Added DTK preference override configuration for theme type settings Influence: 1. Verify that the override configuration file is properly installed to /usr/share/dsg/configs/overrides/org.deepin.dde.shell/ 2. Test that theme type configuration is available through DTK configuration system 3. Check that the themeType setting can be read and written correctly 4. Verify Chinese translations for configuration name and description 5. Ensure the configuration has proper permissions (readwrite) and visibility (public) 6. Test that the override doesn't break existing configuration loading fix: 添加DTK偏好设置覆盖配置 1. 在debian/dde-shell.install中添加覆盖配置文件的安装 2. 更新CMakeLists.txt以安装DTK偏好设置覆盖配置 3. 创建新的覆盖文件shell/overrides/org.deepin.dtk.preference.json 4. 覆盖文件定义了themeType配置,包含完整元数据和中文翻译 Log: 添加了主题类型设置的DTK偏好设置覆盖配置 Influence: 1. 验证覆盖配置文件是否正确安装到/usr/share/dsg/configs/overrides/ org.deepin.dde.shell/ 2. 测试主题类型配置是否可通过DTK配置系统访问 3. 检查themeType设置能否正确读写 4. 验证配置名称和描述的中文翻译 5. 确保配置具有正确的权限(读写)和可见性(公开) 6. 测试覆盖配置不会破坏现有的配置加载 PMS: BUG-345091
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a DTK configuration override for the dde-shell themeType preference and wires it into both the CMake install and Debian packaging so the override JSON is installed and picked up by the DTK configuration system. Sequence diagram for DTK themeType configuration override loadingsequenceDiagram
participant DdeShell
participant DtkConfigSystem
participant DefaultConfig
participant OverrideConfigFile
DdeShell->>DtkConfigSystem: loadThemeType()
DtkConfigSystem->>DefaultConfig: read(org.deepin.dde.shell.json)
DefaultConfig-->>DtkConfigSystem: themeType default metadata
DtkConfigSystem->>OverrideConfigFile: read(org.deepin.dtk.preference.json)
OverrideConfigFile-->>DtkConfigSystem: themeType override metadata
DtkConfigSystem->>DtkConfigSystem: merge default and override
DtkConfigSystem-->>DdeShell: effective themeType config (public, readwrite)
DdeShell->>DtkConfigSystem: setThemeType(value)
DtkConfigSystem-->>DdeShell: persist themeType value
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deepin pr auto review我来帮你审查这个 git diff。这个变更主要涉及 DDE Shell 的配置文件安装和主题类型配置。让我从多个角度进行分析:
改进建议:
这些改进建议可以帮助提高代码的可维护性、可靠性和用户体验。你觉得这些建议怎么样?需要我详细解释某个方面吗? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
shell.install
configuration
org.deepin.dtk.preference.json
metadata including Chinese translations
Log: Added DTK preference override configuration for theme type settings
Influence:
to /usr/share/dsg/configs/overrides/org.deepin.dde.shell/
configuration system
visibility (public)
fix: 添加DTK偏好设置覆盖配置
Log: 添加了主题类型设置的DTK偏好设置覆盖配置
Influence:
org.deepin.dde.shell/
PMS: BUG-345091
Summary by Sourcery
Add DTK configuration override for dde-shell theme preferences and ensure it is installed with the shell package.
New Features:
Enhancements: