-
Notifications
You must be signed in to change notification settings - Fork 45
fix: Remove deepin-anything user and group #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The deepin-anything user was initially introduced to address dbus security issues. This fix was later replaced, and the remaining deepin-anything user is unnecessary, let's remove it.
As title. Log: Update version to 6.2.11
|
TAG Bot TAG: 6.2.11 |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the Debian packaging scripts to stop creating or managing the dedicated deepin-anything system user and group during package installation, aligning the package behavior with the new requirements. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我来对这个diff进行仔细的审查:
改进建议:
userdel -r deepin-anything || true
if [ "$1" = "configure" ]; then
if [ "$REMOVE_DEEPIN_ANYTHING" = "yes" ]; then
# 删除操作
fi
fi
logger "Removing deepin-anything user and group..."
cleanup_deepin_anything() {
# 清理操作
}
if [ "$1" = "configure" ]; then
cleanup_deepin_anything
fi总体来说,这是一个质量较高的patch,主要改进点是删除用户和组的操作,代码逻辑清晰,安全性考虑周全。建议的改进主要是为了提高代码的可维护性和安全性。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: max-lvs, wangrong1069 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
Summary by Sourcery
Bug Fixes: