Skip to content

Conversation

@rb-union
Copy link
Contributor

Support Qt6.8

  • Update debian/control remove obsolete depends;
  • Compile both Qt5 and Qt6 based packages;
  • Updated CMake configuration to include Qt6 support;
  • Updated method calls for Qt6 compatibility;
  • Removed obsolete files related to Qt5;
  • Update README.md.

Log: Support Qt6.8

@github-actions
Copy link

  • 检测到debian目录文件有变更: debian/image-editor6.1,debian/libimageeditor6-dev.install,debian/libimageeditor6.install,debian/control,debian/libimageeditor.install,debian/rules

  • 检测到敏感词export, unset变动

详情
    {
    "export": {
        "debian/rules": {
            "a": [
                "export QT_SELECT=5"
            ],
            "b": [
                "export QT_SELECT=6"
            ]
        }
    },
    "unset": {
        "libimageviewer/libimageviewer-qt5.cmake": {
            "b": [
                "unset(DTK_VERSION_MAJOR)",
                "unset(IMGE_VERSION_MAJOR)"
            ]
        }
    }
}

@github-actions
Copy link

  • 敏感词检查失败, 检测到3个文件存在敏感词
详情
{
    "libimageviewer/viewpanel/navigationwidget.cpp": [
        {
            "line": "const QString SETTINGS_ALWAYSHIDDEN_KEY = \"NavigationAlwaysHidden\";",
            "line_number": 24,
            "rule": "S106",
            "reason": "Var naming | 131b620167"
        }
    ],
    "debian/image-editor6.1": [
        {
            "line": "https://www.deepin.org/en/original/image-editor/",
            "line_number": 24,
            "rule": "S35",
            "reason": "Url link | 3a5cc1554e"
        }
    ],
    "debian/control": [
        {
            "line": "Homepage: http://www.deepin.org",
            "line_number": 52,
            "rule": "S35",
            "reason": "Url link | 6fe814dfb7"
        }
    ]
}

Support Qt6.8

- Update debian/control remove obsolete depends;
- Compile both Qt5 and Qt6 based packages;
- Updated CMake configuration to include Qt6 support;
- Updated method calls for Qt6 compatibility;
- Removed obsolete files related to Qt5;
- Update README.md.

Log: Support Qt6.8
@github-actions
Copy link

  • 检测到debian目录文件有变更: debian/image-editor6.1,debian/libimageeditor6-dev.install,debian/libimageeditor6.install,debian/control,debian/libimageeditor.install,debian/rules

  • 检测到敏感词export, unset变动

详情
    {
    "export": {
        "debian/rules": {
            "a": [
                "export QT_SELECT=5"
            ],
            "b": [
                "export QT_SELECT=6"
            ]
        }
    },
    "unset": {
        "libimageviewer/libimageviewer-qt5.cmake": {
            "b": [
                "unset(DTK_VERSION_MAJOR)",
                "unset(IMGE_VERSION_MAJOR)"
            ]
        }
    }
}

@github-actions
Copy link

  • 敏感词检查失败, 检测到3个文件存在敏感词
详情
{
    "libimageviewer/viewpanel/navigationwidget.cpp": [
        {
            "line": "const QString SETTINGS_ALWAYSHIDDEN_KEY = \"NavigationAlwaysHidden\";",
            "line_number": 24,
            "rule": "S106",
            "reason": "Var naming | 131b620167"
        }
    ],
    "debian/image-editor6.1": [
        {
            "line": "https://www.deepin.org/en/original/image-editor/",
            "line_number": 24,
            "rule": "S35",
            "reason": "Url link | 3a5cc1554e"
        }
    ],
    "debian/control": [
        {
            "line": "Homepage: http://www.deepin.org",
            "line_number": 52,
            "rule": "S35",
            "reason": "Url link | 6fe814dfb7"
        }
    ]
}

@myk1343
Copy link
Contributor

myk1343 commented Nov 18, 2024

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, rb-union

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union rb-union merged commit a1365a4 into linuxdeepin:develop/qt6.8 Nov 18, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants