Skip to content

Catch sdist exceptions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caspervdw wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Catch sdist exceptions #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b616e09
Continue when sdist fails on one tag
caspervdw Aug 23, 2018
c7ee842
Changelog
caspervdw Aug 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Changelog of tags2sdists
1.3 (unreleased)
----------------

- Nothing changed yet.
- Continue after a failing sdist.


1.2 (2015-05-26)
Expand Down
8 changes: 6 additions & 2 deletions tags2sdists/checkoutdir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from pkg_resources import parse_version
from zest.releaser import release

from tags2sdists.utils import command
from tags2sdists.utils import command, SdistCreationError

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -109,7 +109,11 @@ def create_sdist(self, tag):
self.temp_tagdir = os.path.realpath(os.getcwd())
logger.debug("Tag checkout placed in %s", self.temp_tagdir)
python = sys.executable
logger.debug(command("%s setup.py sdist" % python))
try:
logger.debug(command("%s setup.py sdist" % python))
except SdistCreationError:
logger.error("Sdist exception while building %s" % tag)
return
Copy link
Collaborator

@reinout reinout Aug 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier return je None terwijl er normaliter een path naar een tarball wordt teruggegeven. Gaat dat goed?

Copy link
Author

@caspervdw caspervdw Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja zie hier:

tags2sdists/tags2sdists/packagedir.py

Line 39 in 72f3c66

if tarball is None:

Copy link
Collaborator

@reinout reinout Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik ken m'n eigen code niet meer :-)

tarball = find_tarball(self.temp_tagdir, self.package, tag)
return tarball

Expand Down