fix: only show visible subtypes to user

Author: Draconizations

app/Models/Feature/Feature.php

@@ -291,6 +291,15 @@ public function getAdminPowerAttribute() {
 
     **********************************************************************************************/
 
+    /**
+     * Gets the trait's subtypes that are visible to the current user.
+     *
+     * @param mixed|null $user
+     */
+    public function getSubtypes($user = null) {
+        return $this->subtypes()->visible($user)->get();
+    }
+
     /**
      * Displays the trait's subtypes as an imploded string.
      *

resources/views/world/_feature_entry.blade.php

@@ -25,7 +25,7 @@
         @if ($feature->species_id)
             <div>
                 <strong>Species:</strong> {!! $feature->species->displayName !!}
-                @if (!$feature->subtypes->isEmpty())
+                @if (count($feature->getSubtypes(Auth::User() ?? null)))
                     ({!! $feature->displaySubtypes(Auth::User() ?? null) !!})
                 @endif
             </div>

resources/views/world/_features_index.blade.php

@@ -22,8 +22,8 @@
                                         <i class="fas fa-eye-slash mr-1"></i>
                                     @endif
                                     {!! $feature->first()->displayName !!}
-                                    @if ($showSubtype && count($feature->first()->subtypes))
-                                        <br />(Subtype{{ count($feature->first()->subtypes) > 1 ? 's' : '' }}: {!! $feature->first()->displaySubtypes(Auth::User() ?? null) !!})
+                                    @if ($showSubtype && count($feature->first()->getSubtypes(Auth::User() ?? null)))
+                                        <br />(Subtype{{ count($feature->first()->getSubtypes(Auth::User() ?? null)) > 1 ? 's' : '' }}: {!! $feature->first()->displaySubtypes(Auth::User() ?? null) !!})
                                     @endif
                                 </p>
                             </div>