Skip to content

Conversation

@SpeedyD
Copy link
Contributor

@SpeedyD SpeedyD commented Oct 28, 2024

Based on the conversation in issue #1083 and the original hashing PR #749, I bring you:
Extended Mentions: Re-Extended

..in draft, because I feel like taking a break right now, but wanted to put it up for potential comments.

PR currently adds:
parseItems
parseTraitThumbs
parseItemThumbs
parsePrompts
parsePromptThumbs
(+ idUrl attribute to Prompts Model)

Still on the planning:
parseRarityThumbs
parseSpeciesThumbs
parseSubtypeThumbs
parseShopTumbs
parseCurrencyThumbs
parseCurrencyCategoryThumbs
parseCharacterCategoryThumbs
parsePromptCategoryThumbs
parseTraitCategoryThumbs
parseItemCategoryThumbs

@SpeedyD
Copy link
Contributor Author

SpeedyD commented Oct 28, 2024

And yes, I do in fact plan to also add little text blocks for administration to explain usage, as I did for Character and User mentions prior.

@itinerare itinerare added the enhancement New feature or request label Oct 28, 2024
@itinerare
Copy link
Member

I feel vaguely that at least some of the more niche ones (categories etc) should be behind toggles... at which point they probably all should be,

@SpeedyD
Copy link
Contributor Author

SpeedyD commented Oct 28, 2024

Can do! I'll even do it for the older mentions.

@SpeedyD
Copy link
Contributor Author

SpeedyD commented Oct 30, 2024

Thanks Merc, can always count on you for this. Will fix this all in a bit. :)

@SpeedyD
Copy link
Contributor Author

SpeedyD commented Dec 28, 2024

Note: If #1167 is merged into develop, I'll make sure to merge the develop branch into this PR as to avoid future conflicts.

This was referenced Jan 21, 2025
@SpeedyD
Copy link
Contributor Author

SpeedyD commented Jan 24, 2025

Will likely close this PR after #1205 gets pushed, and make a new one after for the parses that may be left out.
(Which at the point of me typing this comment is literally only the functions I didn't even finish yet. @ScuffedNewt did good work.)

I wish I did not have IRL stopping me from finishing my work on this sorta thing... =_=;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants