Feat(characters): Show only traits belonging to the character's species #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es (or non-species specific traits)
SpeedyD
commented
Nov 27, 2025
itinerare
added
enhancement
ScuffedNewt
reviewed
Nov 28, 2025
ScuffedNewt
reviewed
Nov 28, 2025
ScuffedNewt
reviewed
Nov 28, 2025
ScuffedNewt
approved these changes
Nov 28, 2025
Contributor
ScuffedNewt
left a comment
ScuffedNewt
left a comment
There was a problem hiding this comment.
Only nits on my end, LGTM and huge QoL!
Member
|
Yeah, I don't have the wherewithal to give this a meaningful look atm, but it's really nice QoL. |
Contributor
Author
|
(Note, final commit was automated by Github, all I did was click 'update branch'. It contains no changes and should not count for review.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as non-species specific traits.
Can be turned off with new option in extensions.php.
Second commit adds a refresh on species change- also edited the part for subtypes to be more consistent with other code. :)