fix: Replace deprecated corev1.Endpoints with discoveryv1.EndpointSlice

Replace the deprecated corev1.Endpoints API with discoveryv1.EndpointSlice
in test utility functions to fix linting warnings.

Changes:
- Add discoveryv1 import to tests/e2e/test_utils.go
- Replace corev1.Endpoints with discoveryv1.EndpointSlice in logServiceEndpoints()
- Refactor logServiceEndpoints() into smaller helper functions to reduce complexity:
  - getEndpointSlices() - retrieves EndpointSlices for a service
  - logEndpointSliceDetails() - logs details of a single EndpointSlice
  - logEndpoints() - logs endpoint addresses and returns ready/not-ready counts
  - logPorts() - logs ports from an EndpointSlice

This resolves the staticcheck warning:
  SA1019: corev1.Endpoints is deprecated: This API is deprecated in v1.33+

Signed-off-by: Derek Higgins <derekh@redhat.com>

Author: derekhiggins

tests/e2e/test_utils.go

@@ -13,6 +13,7 @@ import (
 	"github.com/stretchr/testify/require"
 	appsv1 "k8s.io/api/apps/v1"
 	corev1 "k8s.io/api/core/v1"
+	discoveryv1 "k8s.io/api/discovery/v1"
 	apiextv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
 	"k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
@@ -313,34 +314,77 @@ func logPodDetails(t *testing.T, testenv *TestEnvironment, namespace string) {
 func logServiceEndpoints(t *testing.T, testenv *TestEnvironment, namespace, serviceName string) {
 	t.Helper()
 
-	endpoints := &corev1.Endpoints{}
-	err := testenv.Client.Get(testenv.Ctx, types.NamespacedName{
-		Name:      serviceName,
-		Namespace: namespace,
-	}, endpoints)
-
+	endpointSliceList, err := getEndpointSlices(testenv, namespace, serviceName)
 	if err != nil {
-		t.Logf("Failed to get endpoints for service %s: %v", serviceName, err)
+		t.Logf("Failed to get endpoint slices for service %s: %v", serviceName, err)
+		return
+	}
+
+	if len(endpointSliceList.Items) == 0 {
+		t.Logf("🔗 Service %s has no endpoint slices", serviceName)
 		return
 	}
 
-	t.Logf("🔗 Service %s endpoints:", serviceName)
-	for i, subset := range endpoints.Subsets {
-		t.Logf("  Subset %d:", i)
-		// Ready addresses indicate pods that passed health checks and can receive traffic
-		t.Logf("    Ready addresses: %d", len(subset.Addresses))
-		for _, addr := range subset.Addresses {
-			t.Logf("      - %s", addr.IP)
+	t.Logf("🔗 Service %s endpoint slices:", serviceName)
+	for i, endpointSlice := range endpointSliceList.Items {
+		logEndpointSliceDetails(t, i, &endpointSlice)
+	}
+}
+
+// getEndpointSlices retrieves the EndpointSlices for a service.
+func getEndpointSlices(testenv *TestEnvironment, namespace, serviceName string) (*discoveryv1.EndpointSliceList, error) {
+	endpointSliceList := &discoveryv1.EndpointSliceList{}
+	err := testenv.Client.List(testenv.Ctx, endpointSliceList,
+		client.InNamespace(namespace),
+		client.MatchingLabels{"kubernetes.io/service-name": serviceName})
+	return endpointSliceList, err
+}
+
+// logEndpointSliceDetails logs the details of a single EndpointSlice.
+func logEndpointSliceDetails(t *testing.T, index int, endpointSlice *discoveryv1.EndpointSlice) {
+	t.Helper()
+	t.Logf("  EndpointSlice %d (%s):", index, endpointSlice.Name)
+
+	readyCount, notReadyCount := logEndpoints(t, endpointSlice.Endpoints)
+	t.Logf("    Ready endpoints: %d, Not ready endpoints: %d", readyCount, notReadyCount)
+
+	logPorts(t, endpointSlice.Ports)
+}
+
+// logEndpoints logs endpoint addresses and returns counts of ready and not ready endpoints.
+func logEndpoints(t *testing.T, endpoints []discoveryv1.Endpoint) (readyCount, notReadyCount int) {
+	t.Helper()
+	for _, endpoint := range endpoints {
+		isReady := endpoint.Conditions.Ready != nil && *endpoint.Conditions.Ready
+		if isReady {
+			readyCount++
+			for _, addr := range endpoint.Addresses {
+				t.Logf("    Ready address: %s", addr)
+			}
+		} else {
+			notReadyCount++
+			for _, addr := range endpoint.Addresses {
+				t.Logf("    Not ready address: %s", addr)
+			}
 		}
-		// Not ready addresses show pods that exist but failed health checks
-		t.Logf("    Not ready addresses: %d", len(subset.NotReadyAddresses))
-		for _, addr := range subset.NotReadyAddresses {
-			t.Logf("      - %s", addr.IP)
+	}
+	return readyCount, notReadyCount
+}
+
+// logPorts logs the ports from an EndpointSlice.
+func logPorts(t *testing.T, ports []discoveryv1.EndpointPort) {
+	t.Helper()
+	t.Logf("    Ports:")
+	for _, port := range ports {
+		portName := ""
+		if port.Name != nil {
+			portName = *port.Name
 		}
-		t.Logf("    Ports:")
-		for _, port := range subset.Ports {
-			t.Logf("      - %s: %d", port.Name, port.Port)
+		portNum := int32(0)
+		if port.Port != nil {
+			portNum = *port.Port
 		}
+		t.Logf("      - %s: %d", portName, portNum)
 	}
 }