Skip to content

Commit 0299f0f

Browse files
committed
Fix comments
1 parent 107be92 commit 0299f0f

File tree

1 file changed

+21
-22
lines changed

1 file changed

+21
-22
lines changed

clang/lib/CIR/FrontendAction/CIRGenAction.cpp

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -110,12 +110,12 @@ class CIRGenConsumer : public clang::ASTConsumer {
110110

111111
CIRGenAction::OutputType Action;
112112

113-
CompilerInstance &CompInstance;
114-
DiagnosticsEngine &DiagEngine;
115-
[[maybe_unused]] const HeaderSearchOptions &HdrSearchOptions;
116-
CodeGenOptions &CGenOptions;
117-
[[maybe_unused]] const TargetOptions &TgtOptions;
118-
[[maybe_unused]] const LangOptions &LOptions;
113+
CompilerInstance &CI;
114+
DiagnosticsEngine &Diags;
115+
[[maybe_unused]] const HeaderSearchOptions &HeaderSearchOpts;
116+
CodeGenOptions &CodeGenOpts;
117+
[[maybe_unused]] const TargetOptions &TargetOpts;
118+
[[maybe_unused]] const LangOptions &LangOpts;
119119
const FrontendOptions &FeOptions;
120120

121121
std::unique_ptr<raw_pwrite_stream> OutputStream;
@@ -125,22 +125,21 @@ class CIRGenConsumer : public clang::ASTConsumer {
125125
std::unique_ptr<CIRGenerator> Gen;
126126

127127
public:
128-
CIRGenConsumer(CIRGenAction::OutputType Action,
129-
class CompilerInstance &CompInstance,
130-
class DiagnosticsEngine &DiagEngine,
128+
CIRGenConsumer(CIRGenAction::OutputType Action, class CompilerInstance &CI,
129+
class DiagnosticsEngine &Diags,
131130
IntrusiveRefCntPtr<llvm::vfs::FileSystem> VFS,
132-
const class HeaderSearchOptions &HdrSearchOptions,
133-
class CodeGenOptions &CGenOptions,
134-
const class TargetOptions &TgtOptions,
135-
const class LangOptions &LOptions,
131+
const class HeaderSearchOptions &HeaderSearchOpts,
132+
class CodeGenOptions &CodeGenOpts,
133+
const class TargetOptions &TargetOpts,
134+
const class LangOptions &LangOpts,
136135
const FrontendOptions &FeOptions,
137136
std::unique_ptr<raw_pwrite_stream> Os)
138-
: Action(Action), CompInstance(CompInstance), DiagEngine(DiagEngine),
139-
HdrSearchOptions(HdrSearchOptions), CGenOptions(CGenOptions),
140-
TgtOptions(TgtOptions), LOptions(LOptions), FeOptions(FeOptions),
137+
: Action(Action), CI(CI), Diags(Diags),
138+
HeaderSearchOpts(HeaderSearchOpts), CodeGenOpts(CodeGenOpts),
139+
TargetOpts(TargetOpts), LangOpts(LangOpts), FeOptions(FeOptions),
141140
OutputStream(std::move(Os)), FS(VFS),
142-
Gen(std::make_unique<CIRGenerator>(DiagEngine, std::move(VFS),
143-
CGenOptions)) {}
141+
Gen(std::make_unique<CIRGenerator>(Diags, std::move(VFS),
142+
CodeGenOpts)) {}
144143

145144
void Initialize(ASTContext &Ctx) override {
146145
assert(!AstContext && "initialized multiple times");
@@ -215,12 +214,12 @@ class CIRGenConsumer : public clang::ASTConsumer {
215214
FeOptions.ClangIRLifetimeCheck, LifetimeOpts,
216215
FeOptions.ClangIRIdiomRecognizer, IdiomRecognizerOpts,
217216
FeOptions.ClangIRLibOpt, LibOptOpts, PassOptParsingFailure,
218-
CGenOptions.OptimizationLevel > 0, FlattenCir,
217+
CodeGenOpts.OptimizationLevel > 0, FlattenCir,
219218
!FeOptions.ClangIRDirectLowering, EnableCcLowering,
220219
FeOptions.ClangIREnableMem2Reg)
221220
.failed()) {
222221
if (!PassOptParsingFailure.empty()) {
223-
auto D = DiagEngine.Report(diag::err_drv_cir_pass_opt_parsing);
222+
auto D = Diags.Report(diag::err_drv_cir_pass_opt_parsing);
224223
D << FeOptions.ClangIRLifetimeCheckOpts;
225224
} else
226225
llvm::report_fatal_error("CIR codegen: MLIR pass manager fails "
@@ -304,7 +303,7 @@ class CIRGenConsumer : public clang::ASTConsumer {
304303
case CIRGenAction::OutputType::EmitAssembly: {
305304
llvm::LLVMContext LlvmCtx;
306305
bool DisableDebugInfo =
307-
CGenOptions.getDebugInfo() == llvm::codegenoptions::NoDebugInfo;
306+
CodeGenOpts.getDebugInfo() == llvm::codegenoptions::NoDebugInfo;
308307
auto LlvmModule = lowerFromCIRToLLVMIR(
309308
FeOptions, MlirMod, std::move(MlirCtx), LlvmCtx,
310309
FeOptions.ClangIRDisableCIRVerifier,
@@ -313,7 +312,7 @@ class CIRGenConsumer : public clang::ASTConsumer {
313312
BackendAction BackendAction = getBackendActionFromOutputType(Action);
314313

315314
emitBackendOutput(
316-
CompInstance, CGenOptions, C.getTargetInfo().getDataLayoutString(),
315+
CI, CodeGenOpts, C.getTargetInfo().getDataLayoutString(),
317316
LlvmModule.get(), BackendAction, FS, std::move(OutputStream));
318317
break;
319318
}

0 commit comments

Comments
 (0)