[sanitizer_common] [Darwin] Fix typo in AtosSymbolizer error message (#173329)

ndrewh · web-flow · commit b83694201397 · 2025-12-23T02:46:35.000Z
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_mac.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_mac.cpp
@@ -215,8 +215,8 @@ bool AtosSymbolizer::SymbolizePC(uptr addr, SymbolizedStack *stack) {
 
     // Upon failure, ParseCommandOutput returns NULL.
     if (!buf) {
-      Report("WARNING: atos failed to symbolize buf address \"0x%zx\"\n", addr);
-      return NULL;
+      Report("WARNING: atos failed to symbolize address \"0x%zx\"\n", addr);
+      return false;
     }
     cur->info.line = (int)line;
 
diff --git a/compiler-rt/test/asan/TestCases/Darwin/atos-symbolized-recover.cpp b/compiler-rt/test/asan/TestCases/Darwin/atos-symbolized-recover.cpp
@@ -14,6 +14,6 @@ void bar() {
 int main() {
   bar();
   return 0;
-  // CHECK: WARNING: atos failed to symbolize buf address{{.*}}
+  // CHECK: WARNING: atos failed to symbolize address{{.*}}
   // CHECK: {{.*}}atos-symbolized-recover.cpp:[[@LINE-3]]{{.*}}
 }

Original file line number	Diff line number	Diff line change
`@@ -215,8 +215,8 @@ bool AtosSymbolizer::SymbolizePC(uptr addr, SymbolizedStack *stack) {`
`215`	`215`
`216`	`216`	`// Upon failure, ParseCommandOutput returns NULL.`
`217`	`217`	`if (!buf) {`
`218`		`- Report("WARNING: atos failed to symbolize buf address \"0x%zx\"\n", addr);`
`219`		`- return NULL;`
	`218`	`+ Report("WARNING: atos failed to symbolize address \"0x%zx\"\n", addr);`
	`219`	`+ return false;`
`220`	`220`	`}`
`221`	`221`	`cur->info.line = (int)line;`
`222`	`222`
Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,6 @@ void bar() {`
`14`	`14`	`int main() {`
`15`	`15`	`bar();`
`16`	`16`	`return 0;`
`17`		`- // CHECK: WARNING: atos failed to symbolize buf address{{.*}}`
	`17`	`+ // CHECK: WARNING: atos failed to symbolize address{{.*}}`
`18`	`18`	`// CHECK: {{.}}atos-symbolized-recover.cpp:[[@LINE-3]]{{.}}`
`19`	`19`	`}`