Skip to content

Commit bf93286

Browse files
[compiler-rt] Remove REQUIRES: shell lines (#173338)
The shell feature only implies that we are not running on Windows now that the internal shell is enabled by default everywhere. Remove where we can and rewrite to the more intentional UNSUPPORTED: system-windows when we still need to prevent tests from running on Windows.
1 parent 4e44e87 commit bf93286

File tree

15 files changed

+13
-22
lines changed

15 files changed

+13
-22
lines changed

compiler-rt/test/asan/TestCases/Linux/allocator_oom_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
// ASan shadow memory on s390 is too large for this test.
4444
// AArch64 bots fail on this test.
4545
// TODO(alekseys): Android lit do not run ulimit on device.
46-
// REQUIRES: shell, shadow-scale-3
46+
// REQUIRES: shadow-scale-3
4747
// UNSUPPORTED: android, target={{(s390|aarch64|powerpc64le).*}}
4848

4949
#include <stdlib.h>

compiler-rt/test/asan/TestCases/Posix/deep_call_stack.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
// Check that UAR mode can handle very deep recursion.
2-
// REQUIRES: shell
32
// TODO(boomanaiden154): This test currently fails with the internal
43
// shell because python is not able to set RLIMIT_STACK. We should
54
// reenable this when the behavior is fixed.

compiler-rt/test/asan/TestCases/log-path_test.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
// FIXME: https://code.google.com/p/address-sanitizer/issues/detail?id=316
22
// UNSUPPORTED: ios, android
33
//
4-
// The for loop in the backticks below requires bash.
5-
// REQUIRES: shell
6-
//
74
// RUN: %clangxx_asan %s -o %t
85

96
// Regular run.
@@ -35,7 +32,7 @@
3532
// RUN: not cat %t.log.*
3633

3734
// FIXME: log_path is not supported on Windows yet.
38-
// XFAIL: target={{.*windows-msvc.*}}
35+
// UNSUPPORTED: system-windows
3936

4037
#include <stdlib.h>
4138
#include <string.h>

compiler-rt/test/asan/TestCases/scariness_score_test.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,11 @@
7373
// RUN: not %run %t 27 2>&1 | FileCheck %s --check-prefix=CHECK27
7474
// Parts of the test are too platform-specific:
7575
// REQUIRES: x86_64-target-arch
76-
// REQUIRES: shell
7776
// TODO(boomanaiden154): This test currently fails with the internal
7877
// shell because python is not able to set RLIMIT_STACK. We should
79-
// reenable this when the behavior is fixed.
80-
// UNSUPPORTED: system-darwin
78+
// reenable this when the behavior is fixed. Windows does not support
79+
// ulimit.
80+
// UNSUPPORTED: system-darwin, system-windows
8181
#include <stdlib.h>
8282
#include <stdio.h>
8383
#include <string.h>

compiler-rt/test/fuzzer/features_dir.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Tests -features_dir=F
2-
# REQUIRES: linux, shell
2+
# REQUIRES: linux
33
RUN: %cpp_compiler %S/SimpleTest.cpp -o %t-SimpleTest
44
RUN: rm -rf %t-C %t-F
55
RUN: mkdir %t-C %t-F

compiler-rt/test/fuzzer/fork-sigusr.test

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
# Check that libFuzzer honors SIGUSR1/SIGUSR2
22
# Disabled on Windows which does not have SIGUSR1/SIGUSR2.
3-
REQUIRES: shell
43
UNSUPPORTED: darwin, target={{.*windows.*}}, target=aarch64{{.*}}
54
RUN: rm -rf %t
65
RUN: mkdir -p %t

compiler-rt/test/fuzzer/merge-posix.test

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
REQUIRES: shell
21
XFAIL: ios
32
RUN: %cpp_compiler %S/FullCoverageSetTest.cpp -o %t-FullCoverageSetTest
43

compiler-rt/test/fuzzer/merge-sigusr.test

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# Check that libFuzzer honors SIGUSR1/SIGUSR2
22
# FIXME: Disabled on Windows for now because of reliance on posix only features
33
# (eg: export, "&", pkill).
4-
REQUIRES: shell
54
UNSUPPORTED: darwin, target={{.*windows.*}}
65
RUN: rm -rf %t
76
RUN: mkdir -p %t

compiler-rt/test/fuzzer/sigint.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
REQUIRES: shell, msan
1+
REQUIRES: msan
22
UNSUPPORTED: target=arm{{.*}}
33

44
# Check that libFuzzer exits gracefully under SIGINT with MSan.

compiler-rt/test/fuzzer/sigusr.test

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
# FIXME: Disabled on Windows for now because of reliance on posix only features
22
# (eg: export, "&", pkill).
3-
REQUIRES: shell
43
UNSUPPORTED: darwin, target={{.*windows.*}}
54
# Check that libFuzzer honors SIGUSR1/SIGUSR2
65
RUN: rm -rf %t

0 commit comments

Comments
 (0)