Merge pull request #240 from Dantemss/dont_export_parts_of_multiparts

Don't export parts of multiparts

Author: jpslav

app/controllers/questions_controller.rb

@@ -1,4 +1,4 @@
-# Copyright 2011-2012 Rice University. Licensed under the Affero General Public 
+# Copyright 2011-2012 Rice University. Licensed under the Affero General Public
 # License version 3 or later.  See the COPYRIGHT file for details.
 
 class QuestionsController < ApplicationController
@@ -13,31 +13,31 @@ class QuestionsController < ApplicationController
   before_filter :except => [:index, :new, :get_started, :search] do @use_columns = true end
 
   # before_filter {@include_autocomplete=true}
-    
+
   autocomplete :tag, :name, :class_name => 'ActsAsTaggableOn::Tag'
-  
+
   def index
     @where ||= 'Published Questions'
   end
 
   def show
     @question = Question.from_param(params[:id])
     @unfinished_solutions = !@question.solutions.where{(is_visible == false) & (creator_id == my{present_user.id})}.first.nil?
-    raise SecurityTransgression unless present_user.can_read?(@question) || 
+    raise SecurityTransgression unless present_user.can_read?(@question) ||
                                        ((request.remote_ip == '50.116.31.239'))
-    
+
     start_time = Time.now if logger.info?
-    
+
     @question.variate!(QuestionVariator.new(params[:seed]))
-    
+
     logger.info {"Variated question #{@question.to_param} with seed " +
                  "#{params[:seed] || '[unset]'}, duration = #{Time.now-start_time}"}
-          
+
     respond_to do |format|
       format.json
-      format.html 
-      format.qti { 
-        render :template => case params[:version] 
+      format.html
+      format.qti {
+        render :template => case params[:version]
                             when "1.2", nil
                               "#{view_dir(@question)}/show.1p2"
                             else
@@ -60,18 +60,18 @@ def history
 
   def new
   end
-  
+
   def get_started
   end
-  
+
   def create_simple
     create(SimpleQuestion.new)
   end
-  
+
   def create_multipart
     create(MultipartQuestion.new)
   end
-  
+
   def edit
     @question = Question.from_param(params[:id])
     raise SecurityTransgression unless present_user.can_update?(@question)
@@ -83,8 +83,8 @@ def edit
     respond_with(@question)
   end
 
-  
-  # We can't use the normal respond_with here b/c the STI we're using confuses it.  
+
+  # We can't use the normal respond_with here b/c the STI we're using confuses it.
   # Rails tries to render simple_questions/edit when there are update errors, but
   # we just want it to go to the questions view.
   def update
@@ -100,7 +100,7 @@ def update
       return
     end
 
-    respond_to do |format|  
+    respond_to do |format|
        if (@updated = @question.update_attributes(params[:question]))
         flash[:notice] = "Your draft has been saved.
                           Until you publish this draft, please remember that only members of " +
@@ -144,46 +144,46 @@ def preview
       raise ActiveRecord::Rollback
     end
   end
-  
+
   def show_part
     @multipart_question = Question.from_param(params[:question_id])
-    
+
     parts = @multipart_question.child_question_parts
     raise SecurityTransgression unless parts.length >= params[:part_id].to_i
-    
+
     @question = parts[params[:part_id].to_i-1].child_question
-    
+
     raise SecurityTransgression unless present_user.can_read?(@question)
-    
-    
+
+
     respond_to do |format|
       format.html { render 'questions/show' }
     end
   end
-  
+
   def tags
     @tags = Question.tag_counts_on(:tags)
   end
-  
+
   def add_tags
     @question = Question.from_param(params[:question_id])
     raise SecurityTransgression unless present_user.can_tag?(@question)
-    
+
     incoming_tags = params[:tags].split(",").collect{|t| t.strip}.delete_if{|t| t.blank?}
-    
+
     if incoming_tags.empty?
     elsif tags_fail_regex?(incoming_tags)
       flash[:alert] = "Tags can only contain letters, numbers, spaces, hyphens, and apostrophes.  Multiple tags should be separated by commas."
     else
       tags = @question.tag_list.concat(incoming_tags).join(", ")
-      @question.update_attribute(:tag_list, tags)      
-    end   
-    
+      @question.update_attribute(:tag_list, tags)
+    end
+
     respond_to do |format|
       format.js { render :template => 'questions/tags_action' }
-    end 
+    end
   end
-  
+
   def remove_tag
     @question = Question.from_param(params[:question_id])
     raise SecurityTransgression unless present_user.can_tag?(@question)
@@ -194,23 +194,23 @@ def remove_tag
       updated_tag_list = @question.tag_list.reject{|t| target_tag == t}
       @question.update_attribute(:tag_list, updated_tag_list)
     end
-    
+
     respond_to do |format|
       @in_remove_state = true
       format.js { render :template => 'questions/tags_action' }
     end
   end
-  
+
   def tagged
     @tags = params[:tags].gsub("_"," ").split("+")
     @per_page = params[:per_page] || 20
-    
+
     if tags_fail_regex?(@tags)
       @questions = []
       flash[:alert] = "The provided tags contain invalid characters."
     else
       @questions = Question.tagged_with(@tags)
-                           .reject{|q| (q.is_published? && !q.is_latest?) || 
+                           .reject{|q| (q.is_published? && !q.is_latest?) ||
                                         !present_user.can_read?(q)}
                            .paginate(:page => params[:page], :per_page => @per_page)
     end
@@ -231,17 +231,17 @@ def preview_publish
     run_prepublish_error_checks(@questions)
     respond_with(@questions)
   end
-  
+
   def publish
     @questions = Question.find(params[:question_ids])
-    
+
     @questions.each { |q|
       raise SecurityTransgression unless q.can_be_published_by?(present_user)
     }
 
     run_prepublish_error_checks(@questions, false)
     error_message = combine_base_error_messages(@questions)
-    
+
     if !error_message.blank?
       respond_to do |format|
         format.html {
@@ -251,38 +251,38 @@ def publish
         format.any(:json,:xml) { raise NotYetImplemented }
       end
     end
-    
+
     if params[:agreement_checkbox]
       @questions.each { |q|
         q.publish!(present_user)
       }
-      
+
       respond_with(@questions) do |format|
-        format.html { 
-          redirect_to @questions.size == 1 ? 
+        format.html {
+          redirect_to @questions.size == 1 ?
                       question_path(@questions.first) :
                       questions_path
         }
       end
     else
-      flash[:alert] = "You must accept the license agreement in order to publish " + 
+      flash[:alert] = "You must accept the license agreement in order to publish " +
                       ((@questions.size == 1) ? "this question." : "these questions.")
       respond_with(@questions) do |format|
         format.html { redirect_to :back }
       end
     end
   end
-  
+
   def source
     @question = Question.from_param(params[:question_id])
     raise SecurityTransgression unless @question.can_be_read_by?(present_user)
     respond_with(@question)
   end
-  
+
   def new_version
     @source_question = Question.from_param(params[:question_id])
     raise SecurityTransgression unless @source_question.can_be_new_versioned_by?(present_user)
-    
+
     begin
       @question = @source_question.new_version!(present_user)
       respond_to do |format|
@@ -293,7 +293,7 @@ def new_version
       flash[:alert] = "We could not create a derived question as requested."
       respond_to do |format|
         format.html { redirect_to question_path(@source_question) }
-      end      
+      end
     end
   end
 
@@ -306,7 +306,7 @@ def derivation_dialog
 
     respond_to do |format|
       format.js
-    end     
+    end
   end
 
   def new_derivation
@@ -315,7 +315,7 @@ def new_derivation
     edit_now = params[:edit] == "now"
     raise SecurityTransgression unless (@source_question.can_be_derived_by?(present_user) &&
       (!list.nil? && list.can_be_updated_by?(present_user)))
-    
+
     begin
       @question = @source_question.new_derivation!(present_user, list)
       flash[:notice] = "Derived question created.
@@ -343,23 +343,23 @@ def new_derivation
     false
   end
 
-  # Originally, the license was set with the other attributes on the 
-  # new/edit/update pages.  However, we decided to break that out into a 
-  # separate page b/c it wasn't super critical (and because we are going to 
+  # Originally, the license was set with the other attributes on the
+  # new/edit/update pages.  However, we decided to break that out into a
+  # separate page b/c it wasn't super critical (and because we are going to
   # start questions with a default license.)  These methods support those pages.
-  
+
   def edit_license
     @question = Question.from_param(params[:question_id])
     raise SecurityTransgression unless present_user.can_update?(@question)
     respond_with(@question)
   end
-  
+
   def update_license
     @question = Question.from_param(params[:question_id])
     raise SecurityTransgression unless present_user.can_update?(@question)
 
     @question.license = License.find(params[:question][:license_id])
-    
+
     respond_to do |format|
       if @question.save
         format.html { redirect_to question_path(@question) }
@@ -370,6 +370,9 @@ def update_license
   end
 
   def search
+    render text: 'Question search has been temporarily disabled.'
+    return
+
     @type = params[:type]
     @location = params[:location]
     @part = params[:part]
@@ -403,34 +406,34 @@ def evaluate
       end
     end
   end
-  
+
 protected
 
-  def create(question) 
+  def create(question)
     @question = question
     raise SecurityTransgression unless present_user.can_create?(@question)
-                    
+
     begin
       @question.create!(current_user)
-    
+
       respond_to do |format|
         format.html { redirect_to edit_question_path(@question) }
       end
     rescue ActiveRecord::RecordInvalid => invalid
       logger.error {"An error occurred when creating a question: #{invalid.message}"}
-    
+
       respond_to do |format|
-        format.html {   
+        format.html {
           begin
             redirect_to :back
           rescue ActionController::RedirectBackError
-            redirect_to root_path 
+            redirect_to root_path
           end
         }
-      end      
+      end
     end
   end
-  
+
   def tags_fail_regex?(tags)
     tags = [tags].flatten
     tags.any?{|tag| (tag =~ /^[A-Za-z\d\-' ]+$/).nil?}

lib/tasks/questions/export/json.rake

@@ -15,6 +15,10 @@ namespace :questions do
                             .where{(question_collaborators.user_id == user_id) | \
                                    (list_questions.list.list_members.user_id == user_id)}
 
+      # Remove parts of multipart questions
+      questions = questions.joins{parent_question_parts.outer}
+                           .where(parent_question_parts: {id: nil})
+
       questions = questions.includes(:taggings => :tag)
                            .includes(:list_questions => :list)
                            .includes(:solutions).uniq.to_a