filter/clone/documentation optional option "clones" seems not to be optional

[jordansissel]

(This issue was originally filed by @widhalmt at elastic/logstash#2141)

---

I treid the clone filter without giving the clones option and was hoping that it would create clones with the same type as the original event. But no clones were created.

clone {
  add_tag => [ "cloned", "icinga_alert" ]
}

Using the following clones are created.

clone {
  add_tag => [ "cloned", "icinga_alert" ]
  clones => [ "clone" ]
}

Maybe I misread the documentation because both configurations get through the configtestof logstash but since the first example doesn't do anything I would have liked at least a hint that it won't do anything.

[jpcarey]

I hate +1s, but +1. I read the doc that no settings were necessary. I setup so all events that existed inside of an if block would have been cloned. This did not work, and I had to go back and setup a separate mutate => add_field => type=X, and then clone => clones => X

[jordansissel]

Hmm, Yeah I think y'all are right. We should make clones required, right?

[wiibaa]

@jordansissel so you mean I overdid it in #6 :P

[jordansissel]

@wiibaa haha, overdid? Not sure. That looks like a bunch of nice new features. We'll get to reviewing it soon ;P