From bfeb178ca2cc26b5557101d0cc22b61057b893f4 Mon Sep 17 00:00:00 2001 From: Kamil Date: Wed, 8 Apr 2026 17:18:05 +0200 Subject: [PATCH] refactor: remove redundant level property from typed logger calls When using Winston's `.error()` or `.warn()` methods, the level is already set by the method itself. Passing `level: "error"` to `.error()` or `level: "warn"` to `.warn()` is redundant. Also changed one `.log({ level: "warn" })` call to `.warn()` for consistency within the same file. Co-Authored-By: Claude Opus 4.6 (1M context) --- .../src/activities/services/activities-events.service.ts | 5 +---- apps/api/src/kills/kills.service.ts | 2 -- apps/api/src/timers/timers.service.ts | 2 -- 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/apps/activity/src/activities/services/activities-events.service.ts b/apps/activity/src/activities/services/activities-events.service.ts index deacd7e8..00233325 100644 --- a/apps/activity/src/activities/services/activities-events.service.ts +++ b/apps/activity/src/activities/services/activities-events.service.ts @@ -53,7 +53,6 @@ export class ActivitiesEventsService { if (!result.success) { this.logger.error({ - level: "error", message: "Invalid activity payload - validation failed (permanent error, sending to DLQ)", rawPayload: data, @@ -94,7 +93,6 @@ export class ActivitiesEventsService { await this.activitiesService.create(dto); } catch (error) { this.logger.error({ - level: "error", message: "Failed to create activity", error: error instanceof Error ? error.message : String(error), stack: error instanceof Error ? error.stack : undefined, @@ -116,8 +114,7 @@ export class ActivitiesEventsService { }, }) handleActivityCreateDlq(@RabbitPayload() message: unknown) { - this.logger.log({ - level: "warn", + this.logger.warn({ message: "Activity CREATE DLQ message - manual intervention needed", rawPayload: message, }); diff --git a/apps/api/src/kills/kills.service.ts b/apps/api/src/kills/kills.service.ts index 3d9bf991..a540e95e 100644 --- a/apps/api/src/kills/kills.service.ts +++ b/apps/api/src/kills/kills.service.ts @@ -82,7 +82,6 @@ export class KillsService { }); } catch (error) { this.logger.error({ - level: "error", message: "Failed to upsert user kill stats", error: error instanceof Error ? error.message : error, }); @@ -205,7 +204,6 @@ export class KillsService { return { guildId, isFirstGuildKill }; } catch (error) { this.logger.error({ - level: "error", message: `Failed to upsert kill stats for guildId ${guildId}`, error: error instanceof Error ? error.message : error, }); diff --git a/apps/api/src/timers/timers.service.ts b/apps/api/src/timers/timers.service.ts index a1aa77ae..2ee6fefd 100644 --- a/apps/api/src/timers/timers.service.ts +++ b/apps/api/src/timers/timers.service.ts @@ -281,7 +281,6 @@ export class TimersService implements OnModuleInit { }; } catch (error) { this.logger.warn({ - level: "warn", message: "Failed to resolve synthetic timer context for event hero", guildId, world, @@ -788,7 +787,6 @@ export class TimersService implements OnModuleInit { }) .catch((error) => { this.logger.error({ - level: "error", message: "Failed to enqueue event hero kill check", error: error instanceof Error ? error.message : error, guildId,