Remove position and exec_async options

Use window split mods instead of position and detect exec_async by vim
version

Author: lucerion

autoload/executor.vim

@@ -8,32 +8,30 @@
 " ===========================================================================
 
 let s:previous_buffer = ''
-let s:positions = ['top', 'bottom', 'left', 'right', 'tab']
-let s:default_position = 'bottom'
 
-func! executor#exec(start_line, end_line, open_result, ...) abort
+func! executor#exec(start_line, end_line, open_result, mods, ...) abort
   if !exists('g:loaded_buffr')
     call s:show_error('Please, install vim-buffr plugin first') | return
   endif
 
   let l:command = join(a:000)
   let l:selection = getline(a:start_line, a:end_line)
 
-  if g:executor_exec_async && (v:version >= 800)
-    call executor#async#exec(l:command, l:selection, a:open_result)
+  if v:version >= 800
+    call executor#async#exec(l:command, l:selection, a:open_result, a:mods)
   else
-    call executor#default#exec(l:command, l:selection, a:open_result)
+    call executor#default#exec(l:command, l:selection, a:open_result, a:mods)
   endif
 endfunc
 
-func! executor#open_result(result, command) abort
+func! executor#open_result(result, command, mods) abort
   let l:buffer_name = s:buffer_name(a:command)
-  call s:open_buffer(l:buffer_name)
+  call s:open_buffer(l:buffer_name, a:mods)
   call append(0, a:result)
   silent normal! Gddgg
 endfunc
 
-func! s:open_buffer(buffer_name) abort
+func! s:open_buffer(buffer_name, mods) abort
   let l:buffer_name = a:buffer_name
 
   if g:executor_reuse_buffer
@@ -43,10 +41,7 @@ func! s:open_buffer(buffer_name) abort
     let s:previous_buffer = a:buffer_name
   endif
 
-  call buffr#open_or_create_buffer({
-    \ 'position': s:buffer_position(),
-    \ 'name': l:buffer_name
-    \ })
+  call buffr#open_or_create_buffer(l:buffer_name, a:mods)
   call s:set_buffer_defaults()
 
   if g:executor_reuse_buffer
@@ -63,10 +58,6 @@ func! s:buffer_name(command) abort
   return l:name
 endfunc
 
-func! s:buffer_position() abort
-  return index(s:positions, g:executor_position) < 0 ? s:default_position : g:executor_position
-endfunc
-
 func! s:set_buffer_defaults() abort
   setlocal buftype=nofile
   setlocal bufhidden=wipe

autoload/executor/async.vim

@@ -7,14 +7,15 @@
 " Licence:      BSD-3-Clause
 " ===========================================================================
 
-func! executor#async#exec(command, selection, open_result) abort
+func! executor#async#exec(command, selection, open_result, mods) abort
   let s:command = a:command
   let s:result = []
   let s:open_result = a:open_result
-  call s:execute(a:command, a:selection)
+  let s:mods = a:mods
+  call s:execute(a:command, a:selection, a:mods)
 endfunc
 
-func! s:execute(command, selection) abort
+func! s:execute(command, selection, mods) abort
   let l:command = a:command
 
   if len(a:selection) == 1 && !empty(a:selection[0])
@@ -38,6 +39,6 @@ endfunc
 
 func! s:exit_callback(job, status) abort
   if s:open_result
-    call executor#open_result(s:result, s:command)
+    call executor#open_result(s:result, s:command, s:mods)
   endif
 endfunc

autoload/executor/default.vim

@@ -7,10 +7,10 @@
 " Licence:      BSD-3-Clause
 " ===========================================================================
 
-func! executor#default#exec(command, selection, open_result) abort
+func! executor#default#exec(command, selection, open_result, mods) abort
   let l:result = s:execute(a:command, a:selection)
   if a:open_result
-    call executor#open_result(split(l:result, "\n"), a:command)
+    call executor#open_result(split(l:result, "\n"), a:command, a:mods)
   endif
 endfunc
 

doc/executor.txt

@@ -21,23 +21,28 @@ INSTALL                                                  *vim-executor-install*
 Vundle                                https://github.com/VundleVim/Vundle.vim
 >
     Plugin 'lucerion/vim-executor'
+    Plugin 'lucerion/vim-buffr'
 <
 Pathogen                                https://github.com/tpope/vim-pathogen
 >
     cd ~/.vim/bundle
     git clone https://github.com/lucerion/vim-executor
+    git clone https://github.com/lucerion/vim-buffr
 <
 NeoBundle                             https://github.com/Shougo/neobundle.vim
 >
     NeoBundle 'lucerion/vim-executor'
+    NeoBundle 'lucerion/vim-buffr'
 <
 vim-plug                                 https://github.com/junegunn/vim-plug
 >
     Plug 'lucerion/vim-executor'
+    Plug 'lucerion/vim-buffr'
 <
 Manual
 >
     git clone https://github.com/lucerion/vim-executor
+    git clone https://github.com/lucerion/vim-buffr
 <
     copy all of the files into your ~/.vim directory
 
@@ -52,17 +57,13 @@ COMMANDS                                                *vim-executor-commands*
                               then one - passes to command as an argument.
                               If ! is given, buffer with the result not
                               be opened.
+                              Window split modes (|leftabove|, |rightbelow|,
+                              |topleft|, |botright|, |vsplit|, |tab|, etc)
+                              are available.
 
 ===============================================================================
 OPTIONS                                                  *vim-executor-options*
 
-                                                          *g:executor_position*
-
-Result buffer position.
-
-  Possible values: 'top', 'bottom', 'left', 'right', 'tab'
-  Default value: 'bottom'
-
                                                        *g:executor_buffer_name*
 
 A pattern for a buffer name. {command} will be replaced with executed command,
@@ -76,12 +77,6 @@ Reuse buffer with results instead of opening a new one.
 
   Default value: 0
 
-                                                        *g:executor_exec_async*
-
-Enable/disable async command execution (only for vim version > 8.0).
-
-  Default value: 1
-
 ===============================================================================
 CHANGELOG                                              *vim-executor-changelog*
 

plugin/executor.vim

@@ -12,10 +12,6 @@ if exists('g:loaded_executor') || &compatible || v:version < 700
 endif
 let g:loaded_executor = 1
 
-if !exists('g:executor_position')
-  let g:executor_position = 'bottom'
-endif
-
 if !exists('g:executor_buffer_name')
   let g:executor_buffer_name = '{command}'
 endif
@@ -24,8 +20,5 @@ if !exists('g:executor_reuse_buffer')
   let g:executor_reuse_buffer = 0
 endif
 
-if !exists('g:executor_exec_async')
-  let g:executor_exec_async = 1
-endif
-
-comm! -nargs=+ -bang -range=0 -complete=shellcmd Exec call executor#exec(<line1>, <line2>, empty('<bang>'), <q-args>)
+comm! -nargs=+ -bang -range=0 -complete=shellcmd Exec
+  \ call executor#exec(<line1>, <line2>, empty('<bang>'), <q-mods>, <q-args>)