buf-move-left: Symbol’s value as variable is void: settings

[starenka]

Hi folks, the last commit broke my buff-move: buf-move-left: Symbol’s value as variable is void: settings
It works okay, if I revert back to this commit...

https://raw.githubusercontent.com/lukhas/buffer-move/25b7a989cf43414559717f87279654305b13e7c9/buffer-move.el

happy to provide some more info if needed

[lukhas]

Hello,

What is your Emacs version? I'll try to reproduce with minimal config.

[starenka]

Hi lukhas,

GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0) of 2021-11-27, modified by Debian

[deescuderoo]

Having the same issue here:

GNU Emacs 28.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.17.6) of 2022-04-27

[jeffpollock9]

+1 on emacs 27.2

[phlo46]

Same here:

GNU Emacs 28.1 (build 1, x86_64-apple-darwin20.6.0, Carbon Version 164 AppKit 2022.6) of 2022-04-09

[ChauhanT]

+1 ! Occuring for me too. Emacs 27.1 on a Debian 11 system.

[zackteo]

Same here on Emacs 28.1. Right now this variant of buffer-move.el will works for me instead https://www.emacswiki.org/emacs/buffer-move.el

[JuanManuelM]

Hello, it seems that the culprit is in:

buffer-move/buffer-move.el

Line 110 in e7800b3

settings

If I remove the .elc file and load the .el file (or byte-compile it again), everything
works fine again (Emacs 28.1).

[aaronjensen]

Reverting this commit fixes it too: 25b7a98

[jkmingwen]

@JuanManuelM Hi, sorry, just wanted to clarify what exactly you did? Did you remove line 110 and recompile the .el file?

[starenka]

Reverting this commit fixes it too: 25b7a98

as i wrote in the initial comment :P

[aaronjensen]

@starenka with respect, your initial comment included a suggestion to "revert back to this commit", which is not the same as reverting a commit. Instead, it implies resetting to that particular commit. Resetting to that commit did not fix it, because that commit was the problematic one. You could have said revert to the commit proceeding that commit or provided the hash of the proceeding commit. My suggestion was to revert the commit itself, which also fixes it.

That all said, for some reason, master works for me again on GNU Emacs 29.0.50 (build 1, aarch64-apple-darwin21.6.0, NS appkit-2113.60 Version 12.5.1 (Build 21G83)) of 2022-08-20

[starenka]

@aaronjensen hehe, no respect needed, we are all on same boat i guess. Nevertheless I really meant "revert to this commit", because it worked for me :D

look:

starenka /tmp % wget -q https://raw.githubusercontent.com/lukhas/buffer-move/25b7a989cf43414559717f87279654305b13e7c9/buffer-move.el -O - | diff `find ~/.emacs.d -name buffer-move.el` -
starenka /tmp % echo $?                                                                                                                                                                  
0

nevermind, im glad we all found some solution to this.