Skip to content

Compare current syntax highlight with TextMate grammars #70

@macor161

Description

@macor161

VSCode uses TextMate grammar for its syntax highlighting.

Benefits:

  • Implementation already available
  • Less maintenance when Solidity language changes occur

Drawbacks:

  • Slower
  • Doesn't handle partial code, as it is required in errors and warnings.
  • Maybe difficult to integrate line/column indicator for warnings and errors

We should :

  • Determine how much slower the TextMate implementation is.
  • Examine the possibility of removing partial code requirements. i.e. Syntax highlight the whole file before extracting the snippet of lines of context for the error/warning. Measure the impact on speed of this approach.
  • Estimate the effort necessary for adding line/column indicators.
  • Estimate total effort of migrating to TextMate syntax highlighting

Solidity syntax highlight example currently used in VSCode solidity extension: https://github.com/juanfranblanco/vscode-solidity/blob/master/syntaxes/solidity.json

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions