Bug: find a way to deal with multi-pool reservation cleanup.

[mafudge]

There's an issue where reservations are not being cleaned up. This happens in multi-pool setups where all the seats have been reserved.

I'm thinking we need to check for cleanup at request to a homepage.

[mafudge]

potential fix? Run this stored procedure against the page displaying pools? Remove code to cleanup at the pool level - won't be necessary.

`

CREATE PROCEDURE [dbo].[P_remotelabdb_reservation_cleanup_all_pools]
as
begin
SET NOCOUNT ON;
declare @now datetime
declare @compname varchar(50)
declare @username varchar(50)
declare @poolname varchar(50)
declare cleanupCursor cursor fast_forward for
select ComputerName, UserName, PoolName
from dbo.Computers join Pools on Pool_PoolName = PoolName
where (Reserved IS NOT NULL) AND (Logon IS NULL) AND (UserName IS NOT NULL)
AND DATEDIFF(mi,Reserved,GETDATE())>=CleanupInMinutes
open cleanupCursor
fetch next from cleanupCursor into @compname, @username, @poolname
while @@FETCH_STATUS= 0
begin
update Computers set
UserName = null,
Logon = null,
Reserved = null
where ComputerName= @compname
set @now = getdate()
exec dbo.P_remotelabdb_logevent 'EXPIRED RESERVATION', @username, @compname,@poolname, @now
fetch next from cleanupCursor into @compname, @username, @poolname
end
close cleanupCursor
deallocate cleanupCursor
END
GO

`