Addons do not load correctly after update

[MarvinKlar]

Hi,

I did update my server from Paper 1.20.4 to Paper 1.21.11. After the update my custom addon does no longer work after server startup. Only if I do a /shop reload. It implements the following logic:

public class MythicMobItemDataPart extends ItemDataPart implements Listener {
    private final LocaleManager localeManager;
    private final ItemExecutor itemExecutor;

    public MythicMobItemDataPart(LocaleManager localeManager, ItemExecutor itemExecutor) {
        this.localeManager = localeManager;
        this.itemExecutor = itemExecutor;
    }

    @EventHandler
    public void onRegister(GenesisRegisterTypesEvent event) {
        this.register();
    }

    @Override
    public ItemStack transform(ItemStack item, String usedName, String mmItemName) {
        @Nullable ItemStack mmItem = itemExecutor.getItemStack(mmItemName);
        if (mmItem == null) {
            ClassManager.manager.getBugFinder()
                    .severe("Mistake in Config: '" + mmItemName + "' is not a valid '" + usedName +
                            "'. Please make sure the item exists.");
            return item;
        }
        int amount = item.getAmount();
        item = mmItem;
        item.setAmount(amount);
        return item;
    }

    @Override
    public int getPriority() {
        return PRIORITY_NORMAL;
    }

    @Override
    public boolean removeSpaces() {
        return true;
    }

    @Override
    public String[] createNames() {
        return new String[]{"mmitem"};
    }

    @Override
    public List<String> read(ItemStack i, List<String> output) {
        output.add("type:" + i.getType().name());
        output.add("name:" + localeManager.toServerLocale(localeManager.queryItemStack(i)));
        if (i.getItemMeta() != null && i.getItemMeta().getLore() != null) {
            for (String lore : i.getItemMeta().getLore()) {
                output.add("lore:" + lore);
            }
        }
        return output;
    }

    @Override
    public boolean isSimilar(ItemStack shopItem, ItemStack playerItem, GenesisBuy buy, Player p) {
        return shopItem.getType() == playerItem.getType() &&
                localeManager.toServerLocale(localeManager.queryItemStack(shopItem))
                        .equals(localeManager.toServerLocale(localeManager.queryItemStack(playerItem)));
    }

I did implement everything as described in the BossShopPro Wiki. And the addon did work on the old version just fine. What am I missing? Why did the update broke that addon?! Yan you please help there? Thanks!

[MarvinKlar]

@Blackixx @Travja Do you have any idea?

[Travja]

Do you have a repository you could share?

[MarvinKlar]

No, its not meant to be shared. I posted all relevant code in here

[Logende]

Any error message or it just does nothing? Did you check whether onRegister() and the other functions are called?

[MarvinKlar]

Any error message or it just does nothing? Did you check whether onRegister() and the other functions are called?

@Logende I did not saw any concerning error messages. I checked everything and it seems like all Functions were called the same way as before. At least the constructor and onRegister were called. It might just load to early/late?

Also the other functions are called on startup.

The log looks soemthing like:

[23:08:14] [Server thread/INFO]: [Genesis] Loading server plugin Genesis v1.0.2-R0.35-SNAPSHOT
[23:08:16] [Server thread/INFO]: [BSPMythicMobsAddon] Loading server plugin BSPMythicMobsAddon v2.0.0
[23:08:32] [Server thread/INFO]: [Genesis] Enabling Genesis v1.0.2-R0.35-SNAPSHOT
[23:08:32] [Server thread/INFO]: [Genesis] Loading data...
[23:08:32] [Server thread/INFO]: [Genesis] Hooked into PlaceholderAPI.
[23:08:36] [Server thread/INFO]: [BSPMythicMobsAddon] Enabling BSPMythicMobsAddon v2.0.0
[23:08:36] [Server thread/INFO]: [Genesis] Enabling Addon BSPMythicMobsAddon
[23:08:36] [Server thread/INFO]: [Genesis] Enabling Addon LimitedUses
[23:08:44] [Craft Scheduler Thread - 10 - Genesis/INFO]: [Genesis] Successfully hooked into Points plugin Gringotts.
[23:08:44] [Craft Scheduler Thread - 10 - Genesis/WARN]: [MythicMobs] ItemFlag 'HIDE_POTION_EFFECTS' does not exist in >=1.20.5.
[23:08:44] [Craft Scheduler Thread - 10 - Genesis/WARN]: [MythicMobs] ItemFlag 'HIDE_POTION_EFFECTS' does not exist in >=1.20.5.
[23:08:45] [Craft Scheduler Thread - 10 - Genesis/INFO]: [Genesis] Loaded 357 Shops!
[23:08:45] [Craft Scheduler Thread - 10 - Genesis/INFO]: [Genesis] Vault found.

The message [Craft Scheduler Thread - 10 - Genesis/WARN]: [MythicMobs] ItemFlag 'HIDE_POTION_EFFECTS' does not exist in >=1.20.5. does occur some times. I can't really find out why this occours. The String HIDE_POTION_EFFECTS is no longer present in any MythicMobs configs.

[MarvinKlar]

@Logende Do you have any updates on the issue?

[Logende]

@Logende Do you have any updates on the issue?

I have not interacted with the code base for many years, but I think given the current information it is impossible to make any definitive statement. Next steps to debug would be: do the other addons work as expected? And what has changed with the Paper update, etc. And a temporary dirty workaround could be to have some script that always triggers shop reload after a few seconds after a server start.

[MarvinKlar]

Bruh

[MarvinKlar]

@Travja Do you have a suitable solution?

[Travja]

I'm really not sure what's going on here. Nothing really changed on our end. The biggest changes from 1.20.4 to 1.21 come on the Spigot/Paper side in how items are built and stored. Again, nothing fundamentally changed on our end there. My best guess right now is that something changed in how Paper loads plugins or how MythicMobs loads items as a result of Paper item changes. Because we load shop items during startup, if MythicMobs is loading their items post-startup, your add on would fundamentally be missing MM context until a reload (after MM is fully enabled).

Unfortunately, this isn't exactly something directly in my wheelhouse to debug or investigate too much further. I'm not super familiar personally with MM, nor do I have a setup to test anything with. Plus, lacking more context of your code means I'm kind of stuck and can only do some deductive reasoning on what little information there is to sift through.